Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHIRO-443: Creation of session validation scheduler made thread safe #4

Closed
wants to merge 1,607 commits into from
Closed

SHIRO-443: Creation of session validation scheduler made thread safe #4

wants to merge 1,607 commits into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented May 23, 2013

To make sure it is created only once, and to not end up with
multiple daemon threads lurking around in case of heavy load on startup
for session creation.

kaosko and others added 30 commits October 28, 2010 09:24
@kaosko
[maven-release-plugin] prepare release shiro-root-1.1.0
e623f5e 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028237 13f79535-47bb-0310-9956-ffa450edef68
@kaosko
[maven-release-plugin] prepare for next development iteration
9f5877d 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028241 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-18 - removed crowd support source code (but it still exists in …
f80b52b 
…the 1.0.x branch) to ensure it is not included with the release.

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028529 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-180: Updated libraries:
66f5a2c 
spring: 3.0.5.RELEASE
ehcache: 2.2.0
aspectj: 1.6.9
groovy: 1.7.5
quartz: 1.6.1
slf4j: 1.6.1
junit: 4.8.2
easymock: 3.0



git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028530 13f79535-47bb-0310-9956-ffa450edef68
Reverting POM versions to 1.1.0-SNAPSHOT to retry the release
7f57842 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028538 13f79535-47bb-0310-9956-ffa450edef68
fixed erroneous jsp-api artifact reference
f5aaba9 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028572 13f79535-47bb-0310-9956-ffa450edef68
removed use of Java 1.6 method to be 1.5 compatible
e32b21b 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028856 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-208: found known incompatibilities, but they are due to source …
e7ad4e9 
…erasure and one test case - Shiro will run fine on 1.5, it just can't build on it at the moment. I'll create another issue to address this for Shiro 1.1.1 or 1.2

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028866 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-208: fixed erroneous comment
5ede469 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028867 13f79535-47bb-0310-9956-ffa450edef68
[maven-release-plugin] prepare release shiro-root-1.1.0
e9fccee 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028941 13f79535-47bb-0310-9956-ffa450edef68
[maven-release-plugin] prepare for next development iteration
b080420 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028943 13f79535-47bb-0310-9956-ffa450edef68
[maven-release-plugin] rollback the release of shiro-root-1.1.0
d2762cd 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028951 13f79535-47bb-0310-9956-ffa450edef68
[maven-release-plugin] prepare release shiro-root-1.1.0
f8e1524 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028973 13f79535-47bb-0310-9956-ffa450edef68
[maven-release-plugin] prepare for next development iteration
a7df3d7 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1028975 13f79535-47bb-0310-9956-ffa450edef68
Minor adjustments: Created a basic 'AbstractShiroTest' class w/ examp…
e86d0e0 
…le subclass to accompany new 'Testing' documentation page. Upgraded the maven gpg plugin from version 1.0 to 1.1

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1037950 13f79535-47bb-0310-9956-ffa450edef68
Updated example test classes to reflect updated documentation.
0c1cf4e 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1043165 13f79535-47bb-0310-9956-ffa450edef68
Javadoc fix - could be misleading
86b7290 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1043167 13f79535-47bb-0310-9956-ffa450edef68
Fixed bug in AbstractShiroTest implementation that didn't work well w…
de94521 
…hen using only mock Subject instances (without the presence of a SecurityManager)

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1044106 13f79535-47bb-0310-9956-ffa450edef68
Updated trunk to reflect version 1.2.0-SNAPSHOT to reflect forward-in…
e88c793 
…compatible changes and new features. Any point release (1.1.x) bug fixes will be done in the branches/shiro-root-1.1.x branch and merged into the trunk.

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1044157 13f79535-47bb-0310-9956-ffa450edef68
Updated sample Spring application to use the correct Spring libraries…
9568d8c 
…. Now deploys successfully, although Spring remoting is failing for the Swing app.

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1044181 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-221: Finished initial implementation, with accompanying test cases
808bcf5 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1044246 13f79535-47bb-0310-9956-ffa450edef68
removed direct use of Logging provider API in favor of SLF4J
7e0b759 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1044247 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-218: added ASF DOAP file as described here: http://projects.apa…
09b8869 
…che.org/create.html

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1044744 13f79535-47bb-0310-9956-ffa450edef68
@kaosko
FIXED - issue SHIRO-231: Realm shouldn't implement Authorizer but Aut…
bdefbeb 
…horizingRealm should implement it directly

https://issues.apache.org/jira/browse/SHIRO-231
- implemented as specified
- ModularRealmAuthorizer now invokes only AuthorizingRealm to participate in authorization
- Fix AuthorizingRealmTest to expect AuthorizingRealm only


git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1057032 13f79535-47bb-0310-9956-ffa450edef68
@kaosko
FIXED - issue SHIRO-231: Realm shouldn't implement Authorizer but Aut…
5501864 
…horizingRealm should implement it directly

https://issues.apache.org/jira/browse/SHIRO-231
- remove obsolete import

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1057034 13f79535-47bb-0310-9956-ffa450edef68
@kaosko
FIXED - issue SHIRO-231: Realm shouldn't implement Authorizer but Aut…
524469d 
…horizingRealm should implement it directly

https://issues.apache.org/jira/browse/SHIRO-231
- ModularRealmAuthorizer should test for Authorizer type, not AuthorizingRealm

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1057039 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-238: implemented proposed fix
461cf7b 
git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1060114 13f79535-47bb-0310-9956-ffa450edef68
@kaosko
Added tests for path traversal prevention, had implemented them way b…
4600653 
…efore but apparently never committed

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1069525 13f79535-47bb-0310-9956-ffa450edef68
@kaosko
RESOLVED - issue SHIRO-236: Adding <relativePath> to the <parent> ele…
54e318b 
…ment to avoid Maven 3.0.x issue where parent is not in local repo yet.

https://issues.apache.org/jira/browse/SHIRO-236
- applied the proposed patch as is (add relativePath element to the poms)

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1069529 13f79535-47bb-0310-9956-ffa450edef68
@kaosko
RESOLVED - issue SHIRO-243: when method is unauthorized, please inclu…
8ad030a 
…de method info in stack trace

https://issues.apache.org/jira/browse/SHIRO-243
- catch, re-wrap and re-throw AuthorizationException with Method Interceptor specific message

git-svn-id: https://svn.apache.org/repos/asf/shiro/trunk@1069537 13f79535-47bb-0310-9956-ffa450edef68
Les Hazlewood and others added 27 commits July 25, 2012 20:37
[maven-release-plugin] prepare for next development iteration
19fd439 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1365731 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-380: added quick patch fix for runAs. This fix is point-version…
aa19390 
… backwards and forwards compatible. A more suitable longer term solution should be addressed for Shiro 1.3 / 2.0 +

git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1403599 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-380: added unit test for DelegatingSubject interaction
b684480 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1403880 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-403: Applied patch.
29acfda 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1425027 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-389: fixed erroneous Export-Package statement
2a31b43 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1427587 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-415: Updated isLoginAttempt(String authzHeader) to use English …
3e1a8af 
…Locale

git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1442305 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-413: ensured LifecycleUtils.init is called for objects created …
c6ece5e 
…by the ReflectionBuilder. Removed this duplicate functionality from the IniSecurityManagerFactory (don't want to call init twice)

git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1457316 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-351: added URI Path Segment Parameter parsing (with tests at 10…
7bb7e35 
…0% coverage).

git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1468734 13f79535-47bb-0310-9956-ffa450edef68
fixed license header
8233022 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1468737 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-431: added .gitignore. Thanks for the pull request!
af1331f 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1468741 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-418: fixed typo
f4510ff 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1468745 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-390: marked JSP OSGi imports as optional.
c41b900 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1468747 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-399: applied patch. Good test case!
de88cfb 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1468749 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-399: fixed timing issue in test (enforced session would timeout)
da94b43 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1479185 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-399: applied patch, but upgraded AspectJ maven plugin to 1.4
5b4757a 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1479187 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-379: patch applied but with improvements (using concurrent read…
9202c14 
…/write locks)

git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1479202 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-388: added test to verify correct functionality.
8873ba3 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1479208 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-394: applied fix per Jira issue
0b74234 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1479214 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-387: applied recommended servletContext attribute-based solution
73f8247 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1479218 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-423: implemented fix w/ accompanying tests
e20f664 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1479224 13f79535-47bb-0310-9956-ffa450edef68
Updated license header
7fa7a32 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1481403 13f79535-47bb-0310-9956-ffa450edef68
SHIRO-429: fixed bug and added test cases for regression
c1111a5 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1481406 13f79535-47bb-0310-9956-ffa450edef68
[maven-release-plugin] prepare release shiro-root-1.2.2
e68d5f2 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1481441 13f79535-47bb-0310-9956-ffa450edef68
[maven-release-plugin] prepare for next development iteration
2970d4d 
git-svn-id: https://svn.apache.org/repos/asf/shiro/branches/1.2.x@1481443 13f79535-47bb-0310-9956-ffa450edef68
@cstamas
SHIRO-443: Added DCL around creation of session validation scheduler.
5f89003 
To make sure it is created only once, and to not end up with
multiple daemon threads lurking around in case of heavy load on startup
for session creation.
@cstamas
SHIRO-443: Making sure scheduler is enabled only once.
64c542a 
With previous commit scheduler.enableSessionValidation()
would be still invoked more than once. The
ExecutorServiceSessionValidationScheduler implementation
would replace ScheduledExecutorService in that case, which
is undesired.
@cstamas
SHIRO-443: Simplified
5fd8b4b
asfgit pushed a commit that referenced this pull request Mar 25, 2016
@cstamas @bdemers
SHIRO-443: Added DCL around creation of session validation scheduler.
2eaf2e5 
To make sure it is created only once, and to not end up with
multiple daemon threads lurking around in case of heavy load on startup
for session creation.

closes #4
@asfgit asfgit closed this in 2537d08 Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstamas @kaosko @bdemers