Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging mock and validation. #39

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Add logging mock and validation. #39

merged 2 commits into from
Aug 11, 2022

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Aug 11, 2022

No description provided.

@jmjoy jmjoy added the enhancement New feature or request label Aug 11, 2022
@jmjoy jmjoy self-assigned this Aug 11, 2022
@jmjoy jmjoy marked this pull request as ready for review August 11, 2022 03:46
@jmjoy jmjoy requested review from dmsolr and mrproliu August 11, 2022 03:46
@jmjoy jmjoy mentioned this pull request Aug 11, 2022
Merged
3 tasks
mrproliu
mrproliu approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmjoy jmjoy merged commit f4f5ef2 into apache:master Aug 11, 2022
@wu-sheng
Copy link
Member

@jmjoy You should update plugin dev tool in the Java agent repo about this new validation.

@jmjoy
Copy link
Member Author

jmjoy commented Aug 11, 2022

@jmjoy You should update plugin dev tool in the Java agent repo about this new validation.

Where's the location?

@wu-sheng
Copy link
Member

The doc is hosted here, https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md

The website of latest is here, https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/plugin-test/

@jmjoy
Copy link
Member Author

jmjoy commented Aug 11, 2022

The doc is hosted here, https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md

The website of latest is here, https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/plugin-test/

Alright.

@jmjoy
Copy link
Member Author

jmjoy commented Aug 14, 2022

Refer: apache/skywalking-java#294.

@Superskyyy Superskyyy mentioned this pull request Feb 4, 2023
Closed
3 tasks
@wu-sheng wu-sheng mentioned this pull request Feb 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrproliu mrproliu mrproliu approved these changes

@dmsolr dmsolr Awaiting requested review from dmsolr

Assignees

@jmjoy jmjoy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@jmjoy @wu-sheng @mrproliu