Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging. #41

Merged
merged 6 commits into from Aug 12, 2022
Merged

Add logging. #41

merged 6 commits into from Aug 12, 2022

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Aug 8, 2022

  • Move Tracer reporting method to GrpcReporter.
  • Add Logger and LogRecord api.
  • Add logging integration tests.

@jmjoy jmjoy self-assigned this Aug 8, 2022
@jmjoy jmjoy added the enhancement New feature or request label Aug 8, 2022
@jmjoy jmjoy added this to the 0.4.0 milestone Aug 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #41 (7edfd1f) into master (c6ec104) will decrease coverage by 17.30%.
The diff coverage is 6.18%.

@@             Coverage Diff             @@
##           master      #41       +/-   ##
===========================================
- Coverage   44.70%   27.40%   -17.31%     
===========================================
  Files          14       17        +3     
  Lines         378      478      +100     
===========================================
- Hits          169      131       -38     
- Misses        209      347      +138     
Impacted Files Coverage Δ
src/common/system_time.rs 0.00% <ø> (ø)
src/logging/logger.rs 0.00% <0.00%> (ø)
src/logging/record.rs 0.00% <0.00%> (ø)
src/reporter/grpc.rs 0.00% <0.00%> (ø)
src/reporter/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
src/reporter/once_cell.rs 0.00% <0.00%> (ø)
src/skywalking_proto/v3/mod.rs 0.00% <ø> (ø)
src/trace/span.rs 0.00% <ø> (ø)
tests/trace_context.rs 0.00% <ø> (ø)
src/reporter/print.rs 46.66% <46.66%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmjoy
Copy link
Member Author

jmjoy commented Aug 9, 2022

@wu-sheng It seems that skywalking-agent-test-tool does not support the mock of logging, it should be added to doing e2e for logging?

@wu-sheng
Copy link
Member

wu-sheng commented Aug 9, 2022

Yes, it should be added.

@jmjoy
Copy link
Member Author

jmjoy commented Aug 11, 2022

skywalking-agent-test-tool
Add logging mock and validation.
apache/skywalking-agent-test-tool#39

@wu-sheng
Copy link
Member

Please logging APIs in the readme doc.

@jmjoy
Copy link
Member Author

jmjoy commented Aug 12, 2022

Readme updated.

@wu-sheng wu-sheng merged commit b8a4a18 into apache:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants