Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTICE to binary package and fix some typo #128

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Add NOTICE to binary package and fix some typo #128

merged 2 commits into from
Jun 2, 2022

Conversation

hanahmily
Copy link
Contributor

Signed-off-by: Gao Hongtao hanahmily@gmail.com

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Copy link
Contributor

@lujiajing1126 lujiajing1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the year should be changed

dist/NOTICE Outdated Show resolved Hide resolved
wu-sheng
wu-sheng previously approved these changes Jun 2, 2022
@wu-sheng wu-sheng added this to the 0.1.0 milestone Jun 2, 2022
@wu-sheng wu-sheng added the chore label Jun 2, 2022
@wu-sheng
Copy link
Member

wu-sheng commented Jun 2, 2022

@lujiajing1126 I think client lib should follow this fix too? Although gRPC/protobuf makes this change compatible with previous versions.

lujiajing1126
lujiajing1126 previously approved these changes Jun 2, 2022
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@lujiajing1126
Copy link
Contributor

@lujiajing1126 I think client lib should follow this fix too? Although gRPC/protobuf makes this change compatible with previous versions.

Java Client does not have this typo. While moving code there, I've already fixed it.

https://github.com/apache/skywalking-banyandb-java-client/blob/main/src/main/proto/banyandb/v1/banyandb-property.proto#L77

@hanahmily
Copy link
Contributor Author

hanahmily commented Jun 2, 2022

@lujiajing1126 I think client lib should follow this fix too? Although gRPC/protobuf makes this change compatible with previous versions.

After checking the java-client's proto files, I didn't find similar typo. It seems they don't affect the interoperations between client and server.

@hanahmily hanahmily merged commit 7394681 into main Jun 2, 2022
@hanahmily hanahmily deleted the release branch June 2, 2022 12:55
@lujiajing1126
Copy link
Contributor

@lujiajing1126 I think client lib should follow this fix too? Although gRPC/protobuf makes this change compatible with previous versions.

After checking the java-client's proto files, I didn't find similar typo. It seems they don't affect the interoperations between client and server.

Yes. The protocol itself only cares about the position and the type of the field.

@wu-sheng
Copy link
Member

wu-sheng commented Jun 2, 2022

OK, once these objects are not used at client, it is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants