-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NOTICE to binary package and fix some typo #128
Conversation
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the year should be changed
@lujiajing1126 I think client lib should follow this fix too? Although gRPC/protobuf makes this change compatible with previous versions. |
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Java Client does not have this typo. While moving code there, I've already fixed it. |
After checking the java-client's proto files, I didn't find similar typo. It seems they don't affect the interoperations between client and server. |
Yes. The protocol itself only cares about the position and the type of the field. |
OK, once these objects are not used at client, it is good. |
Signed-off-by: Gao Hongtao hanahmily@gmail.com