Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NOTICE to binary package and fix some typo #128

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Add NOTICE to binary package and fix some typo #128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec16dc8
Add NOTICE to binary package and fix some typo
hanahmily Jun 2, 2022
77d27a7
Update CONTRIBUTING.md
hanahmily Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Apache SkyWalking
Copyright 2017-2021 The Apache Software Foundation
Copyright 2017-2022 The Apache Software Foundation

This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
2 changes: 1 addition & 1 deletion api/proto/banyandb/property/v1/property.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/proto/banyandb/property/v1/property.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import "banyandb/model/v1/query.proto";

// Metadata is for multi-tenant use
message Metadata {
// container is created when it recevies the first property
// container is created when it receives the first property
common.v1.Metadata container = 1;
// id identifies a property
string id = 2;
Expand Down
94 changes: 47 additions & 47 deletions api/proto/banyandb/property/v1/rpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/proto/banyandb/property/v1/rpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ message GetResponse {
}

message ListRequest {
banyandb.common.v1.Metadata contaner = 1;
banyandb.common.v1.Metadata container = 1;
}

message ListResponse {
Expand Down
2 changes: 1 addition & 1 deletion banyand/liaison/grpc/property.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (ps *propertyServer) Get(ctx context.Context, req *propertyv1.GetRequest) (
}, nil
}
func (ps *propertyServer) List(ctx context.Context, req *propertyv1.ListRequest) (*propertyv1.ListResponse, error) {
entities, err := ps.schemaRegistry.PropertyRegistry().ListProperty(ctx, req.GetContaner())
entities, err := ps.schemaRegistry.PropertyRegistry().ListProperty(ctx, req.GetContainer())
if err != nil {
return nil, err
}
Expand Down
5 changes: 5 additions & 0 deletions dist/NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Apache SkyWalking
Copyright 2017-2021 The Apache Software Foundation
wu-sheng marked this conversation as resolved.
Show resolved Hide resolved

This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
4 changes: 2 additions & 2 deletions docs/api-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2332,7 +2332,7 @@ Metadata is for multi-tenant use

| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| container | [banyandb.common.v1.Metadata](#banyandb-common-v1-Metadata) | | container is created when it recevies the first property |
| container | [banyandb.common.v1.Metadata](#banyandb-common-v1-Metadata) | | container is created when it receives the first property |
| id | [string](#string) | | id identifies a property |


Expand Down Expand Up @@ -2466,7 +2466,7 @@ Property stores the user defined data

| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| contaner | [banyandb.common.v1.Metadata](#banyandb-common-v1-Metadata) | | |
| container | [banyandb.common.v1.Metadata](#banyandb-common-v1-Metadata) | | |



Expand Down