Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improved in Not Found View #395

Merged
merged 12 commits into from
Mar 6, 2024

Conversation

sivasathyaseeelan
Copy link
Contributor

@sivasathyaseeelan sivasathyaseeelan commented Mar 3, 2024

Fix

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

Feature description

This is a PR which improves the UI of Not found View. In this PR i have deleted NotFoundView.vue and creates a 404 folder in ./ui/src/views, this 404 folder contain NotFound.vue which is the improved UI of Not found View. And I have also changed index.js file in ./ui/src/router to show the newly created NotFound.vue with Header/Navbar.

Relevant Images/Videos

404 Page Not Found

Screencast.from.04-03-24.11.09.24.PM.IST.webm
  • If this is non-trivial feature, paste the links/URLs to the design doc.

  • Update the documentation to include this new feature.

  • Tests(including UT, IT, E2E) are added to verify the new feature.

  • If it's UI related, attach the screenshots below.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes [BanyanDB] UI improvement needed in Not Found View skywalking#11964 .

  • Update the CHANGES log.

Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
@wu-sheng
Copy link
Member

wu-sheng commented Mar 3, 2024

The logo seems not to have transparent background, but as white.
Is there another svg logo?

@wu-sheng wu-sheng added the enhancement New feature or request label Mar 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.31%. Comparing base (f27bbf2) to head (9d0510c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   48.32%   48.31%   -0.02%     
==========================================
  Files         173      173              
  Lines       21566    21566              
==========================================
- Hits        10422    10419       -3     
- Misses      10270    10273       +3     
  Partials      874      874              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanahmily
Copy link
Contributor

The logo seems not to have transparent background, but as white. Is there another svg logo?

No, we only have a "jpge" version. Do we need to create a transparent one? From my perspective, a white background is good enough for me.

@wu-sheng
Copy link
Member

wu-sheng commented Mar 4, 2024

It is better to be. I think this is not hard?

@sivasathyaseeelan
Copy link
Contributor Author

sivasathyaseeelan commented Mar 4, 2024

It is better to be. I think this is not hard?

I got svg logo of banyandb from skywalking-website repo. I will use it!!!

Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
@sivasathyaseeelan
Copy link
Contributor Author

sivasathyaseeelan commented Mar 4, 2024

@wu-sheng @hanahmily Now I have updated this PR with banyan-db.svg and I have attached new UI of Not Found View in this PR. Kindly review this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file to "banyandb.svg"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a license header to this file in order to pass the CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why you moved the page to a subfolder when the filename "NotFoundView" already indicates it's used as a 404 page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change to have a better file structure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense. However, have you considered using the term "errors" instead of "404"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it to Errors instead of 404!

Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
@wu-sheng wu-sheng merged commit f9aab65 into apache:main Mar 6, 2024
14 checks passed
@wu-sheng wu-sheng added this to the 0.6.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants