-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improved in Not Found View #395
UI improved in Not Found View #395
Conversation
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
The logo seems not to have transparent background, but as white. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
- Coverage 48.32% 48.31% -0.02%
==========================================
Files 173 173
Lines 21566 21566
==========================================
- Hits 10422 10419 -3
- Misses 10270 10273 +3
Partials 874 874 ☔ View full report in Codecov by Sentry. |
No, we only have a "jpge" version. Do we need to create a transparent one? From my perspective, a white background is good enough for me. |
It is better to be. I think this is not hard? |
I got svg logo of banyandb from skywalking-website repo. I will use it!!! |
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
@wu-sheng @hanahmily Now I have updated this PR with banyan-db.svg and I have attached new UI of Not Found View in this PR. Kindly review this. |
ui/src/assets/banyan-db.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this file to "banyandb.svg"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a license header to this file in order to pass the CI.
ui/src/views/404/NotFound.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why you moved the page to a subfolder when the filename "NotFoundView" already indicates it's used as a 404 page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change to have a better file structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense. However, have you considered using the term "errors" instead of "404"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it to Errors instead of 404!
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
Fix
Feature description
This is a PR which improves the UI of Not found View. In this PR i have deleted
NotFoundView.vue
and creates a404
folder in./ui/src/views
, this404
folder containNotFound.vue
which is the improved UI of Not found View. And I have also changed index.js file in./ui/src/router
to show the newly createdNotFound.vue
withHeader/Navbar
.Relevant Images/Videos
Screencast.from.04-03-24.11.09.24.PM.IST.webm
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes [BanyanDB] UI improvement needed in Not Found View skywalking#11964 .
Update the
CHANGES
log.