-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improved in Not Found View #395
Changes from 3 commits
b618eea
9b2027e
30ae2f3
d774afc
5ec4886
b264856
13ec774
86472b2
d6bccb6
ba75f6f
9d0510c
6658d56
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you explain why you moved the page to a subfolder when the filename "NotFoundView" already indicates it's used as a 404 page? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I made this change to have a better file structure There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. make sense. However, have you considered using the term "errors" instead of "404"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will change it to Errors instead of 404! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
<!-- | ||
~ Licensed to Apache Software Foundation (ASF) under one or more contributor | ||
~ license agreements. See the NOTICE file distributed with | ||
~ this work for additional information regarding copyright | ||
~ ownership. Apache Software Foundation (ASF) licenses this file to you under | ||
~ the Apache License, Version 2.0 (the "License"); you may | ||
~ not use this file except in compliance with the License. | ||
~ You may obtain a copy of the License at | ||
~ | ||
~ http://www.apache.org/licenses/LICENSE-2.0 | ||
~ | ||
~ Unless required by applicable law or agreed to in writing, | ||
~ software distributed under the License is distributed on an | ||
~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
~ KIND, either express or implied. See the License for the | ||
~ specific language governing permissions and limitations | ||
~ under the License. | ||
--> | ||
|
||
<script setup> | ||
import { ElImage, ElTooltip, ElMenu, ElMenuItem } from 'element-plus' | ||
import userImg from '@/assets/banyan-db.svg' | ||
</script> | ||
|
||
<template> | ||
<div class="display-view"> | ||
<div class="inner-component"> | ||
<el-image :src="userImg" class="display-image" fit="fill"> | ||
<div slot="error" class="image-slot"> | ||
<i class="el-icon-picture-outline"></i> | ||
</div> | ||
</el-image> | ||
<div class="display-message"> | ||
<h1 class="message">404 Page Not Found</h1> | ||
<router-link to="/" class="go-home-link">Go Home</router-link> | ||
</div> | ||
</div> | ||
</div> | ||
</template> | ||
|
||
<style lang="scss" scoped> | ||
.display-view { | ||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
height: 100%; | ||
} | ||
|
||
.inner-component { | ||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
gap: 2rem; | ||
} | ||
|
||
.display-image { | ||
height: 12rem; | ||
} | ||
|
||
.display-message { | ||
display: flex; | ||
flex-direction: column; | ||
justify-content: center; | ||
align-items: center; | ||
font-family: var(--font-family-main); | ||
} | ||
|
||
.message { | ||
font-size: 2.5rem; | ||
} | ||
|
||
.go-home-link { | ||
text-decoration: none; | ||
color: inherit; | ||
font-weight: bold; | ||
font-size: large; | ||
background-color: #ffffff; | ||
padding: 1rem; | ||
border-radius: 1rem; | ||
box-shadow: 0px 0px 10px rgba(0, 0, 0, 0.1); | ||
transition: color 0.3s, transform 0.3s; | ||
} | ||
|
||
.go-home-link:hover { | ||
color: #2c3e50; | ||
transform: scale(1.1); | ||
} | ||
</style> | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this file to "banyandb.svg"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a license header to this file in order to pass the CI.