Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loose restrict of greenlet (#3) #326

Merged
merged 1 commit into from
Nov 4, 2023
Merged

loose restrict of greenlet (#3) #326

merged 1 commit into from
Nov 4, 2023

Conversation

jaychoww
Copy link
Contributor

@jaychoww jaychoww commented Nov 1, 2023

  • If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes:
  • Update the CHANGELOG.md.
  • The latest gevent version (>=22.10.2) has resolved the compatibility issue with greenlet (>=2.0.0). Greenlet (1.1.3) works incorrectly when utilized with Python 3.7 and higher (Python 3.7+ should also employ gevent>=22.10). As a result, we should eliminate the limitation on the greenlet version (<=1.1.3).

@jaychoww
loose restrict of greenlet (#3)
a898a68 
* loose restrict of greenlet

* update poetry.lock

* greenlet version must >= 3

* lint

* fix plugin test

* fix test image

* fix some packages version

* fix Werkzeug

* due to this change: https://github.com/giampaolo/psutil/blob/master/HISTORY.rst#596 , agent can't pass the e2e test with psutil==5.9.6, so fixed the version, until we figure out this issue

---------

Co-authored-by: JayChow <4192339+westarest@users.noreply.github.com>
@wu-sheng wu-sheng added this to the 1.1.0 milestone Nov 1, 2023
@wu-sheng wu-sheng added the enhancement New feature or request label Nov 1, 2023
@Superskyyy
Copy link
Member

Superskyyy commented Nov 1, 2023 •
edited

@jaychoww Thanks! Can you check this comment and confirm the error you encountered in the psutil package? apache/skywalking#11481

@jaychoww
Copy link
Contributor Author

jaychoww commented Nov 2, 2023

@jaychoww Thanks! Can you check this comment and confirm the error you encountered in the psutil package? apache/skywalking#11481

yes, I temperately restrict the psutil<=5.9.5 for this issue.

@Superskyyy
Copy link
Member

Ok, let's merge this first, few related issues seem to be reported to psutil too, I will continue to monitor that and loosen the version requirements once fixed.

@Superskyyy
Copy link
Member

Superskyyy commented Nov 4, 2023 •
edited

Thanks for the PR! @jaychoww

I will initiate a new release soon to incorporate recent changes.

@Superskyyy Superskyyy merged commit 9b1acaa into apache:master Nov 4, 2023
91 checks passed
@Superskyyy Superskyyy mentioned this pull request Nov 4, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superskyyy Superskyyy Superskyyy approved these changes

@kezhenxu94 kezhenxu94 Awaiting requested review from kezhenxu94

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
3 participants
@jaychoww @Superskyyy @wu-sheng