Introduce the BTFhub module #35
Conversation
|
|
||
| ${TMPDIR}/btfhub/tools/btfgen.sh -a ${ARCH} $(each_all_bpf_so_file $FROM) | ||
| mkdir -p ${OUTPUT} | ||
| cp -r ${TMPDIR}/btfhub/custom-archive/* ${OUTPUT} |
There was a problem hiding this comment.
You actually copy some of the files from repo https://github.com/aquasecurity/btfhub-archive into our binary, please remember to add these in our binary license.
There was a problem hiding this comment.
The files under custom-archive are generated by btfgen.sh(btfhub tools), you mean we need to add https://github.com/aquasecurity/btfhub to the binary license? The btfhub-archive are only some archive binary files. Am I right?
There was a problem hiding this comment.
The files under
custom-archiveare generated bybtfgen.sh(btfhub tools), you mean we need to add https://github.com/aquasecurity/btfhub to the binary license? Thebtfhub-archiveare only some archive binary files. Am I right?
Correct me if I'm wrong, btfgen.sh "generates" custom-archive by selecting some of the files from https://github.com/aquasecurity/btfhub-archive , right? If so we should add license https://github.com/aquasecurity/btfhub-archive to binary license
There was a problem hiding this comment.
Yes, I take a look at this project. There are no licenses declared. So we ignore it temprory?
There was a problem hiding this comment.
If it doesn't have a license, we should not use it. Default, the owner has its 100% copyright, and doesn't grant to us and the foundation, even though everything is readable, doesn't mean open-source.
It is better if you open an issue to ask the owner.
There was a problem hiding this comment.
OK, it is not urgent, let's hold this.
There was a problem hiding this comment.
Ok license file created in the btfhub-archive repository. Sorry for the delays. Let me know if there is anything else needed.
There was a problem hiding this comment.
@kezhenxu94 @wu-sheng Hi, the license issue has been resolved, please recheck:)
There was a problem hiding this comment.
@rafaeldtinoco Thanks for fixing this so quickly, and licensed in APLv2.
|
cool! |
Follow Blog: https://kinvolk.io/blog/2022/03/btfgen-one-step-closer-to-truly-portable-ebpf-programs/
I see it could help users running the eBPF program with CO-RE on the old kernel(without recompile kernel), It's pretty cool. So we could add it.