Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to identify a span failure? #2599

Closed
1 task
hlg212 opened this issue May 6, 2019 · 4 comments
Closed
1 task

How to identify a span failure? #2599

hlg212 opened this issue May 6, 2019 · 4 comments
Assignees
Labels
agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Milestone

Comments

@hlg212
Copy link

hlg212 commented May 6, 2019

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion

Question

How to identify a span failure?

I used opentracing to create a custom span

But I haven't found a way to set the state.

I tried several ways, but none of them worked.
version: 6.0.0-GA

        span.setTag("error",true);
        span.setTag("isError",true);

        org.apache.skywalking.apm.toolkit.trace.ActiveSpan.tag("is error","true");
        org.apache.skywalking.apm.toolkit.trace.ActiveSpan.tag("isError","true");

微信图片编辑_20190506134730

@wu-sheng
Copy link
Member

wu-sheng commented May 6, 2019

Error is an API for agent. ActiveSpan#tag doesn't support to do that.
If you want that, try to contribute

  1. Add ActiveSpan#errorin toolkit
  2. Call AbstractSpan#errorOccurred in the toolkit activation.

@wu-sheng wu-sheng added agent Language agent related. help wanted plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels May 6, 2019
@hlg212
Copy link
Author

hlg212 commented May 6, 2019

Because we're trying to associate the system with skywalking.

The realization of this function is expected.

Thank you

@wu-sheng
Copy link
Member

wu-sheng commented May 6, 2019

You could work on this and submit a new pull request. We will be glad to review and help you merge into the main codebase.

@wu-sheng wu-sheng added this to the 6.2.0 milestone May 10, 2019
@wu-sheng wu-sheng added feature New feature and removed help wanted labels May 10, 2019
@wu-sheng
Copy link
Member

@huangpang New APIs provided.

peng-yongsheng pushed a commit that referenced this issue May 14, 2019
* Fix #2546

* Change the stackdepth type

* Fix bug

* Fix CI failed

* fix #2599

* fix ci

* add license

* add ActiveTag error methods

* fix

* fix

* fix doc

* update doc

* update dependencyManagement

* fix
peng-yongsheng pushed a commit that referenced this issue May 14, 2019
* Fix #2546

* Change the stackdepth type

* Fix bug

* Fix CI failed

* fix #2599

* fix ci

* add license

* add ActiveTag error methods

* fix

* fix

* nacos

* nacos

* nacos

* nacos

* fix ci

* support nacos cluster

* fix yml

* fix license

* fix ci

* remove optional

* update license

* update license and doc

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Development

No branches or pull requests

3 participants