-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support span#error in toolkit #2605
Conversation
…/sky-walking into fix/spring-plugin-issue
Fix/spring plugin issue
...n/src/main/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanActivation.java
Show resolved
Hide resolved
@ascrutae Do we need test case for this? |
Support #2599 |
@IanCao I suggest that to add error message or an exception in |
@ascrutae Exception is a log API, do you suggest to add that? |
i have added three error methods and test case
plz review~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ascrutae comments inline.
...main/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanErrorInterceptor.java
Outdated
Show resolved
Hide resolved
...lkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/ActiveSpan.java
Outdated
Show resolved
Hide resolved
...lkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/ActiveSpan.java
Show resolved
Hide resolved
@wu-sheng please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline.
...main/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanDebugInterceptor.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanErrorMsgInterceptor.java
Outdated
Show resolved
Hide resolved
...a/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanErrorThrowableInteceptor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/skywalking/apm/toolkit/activation/trace/ActiveSpanInfoInterceptor.java
Outdated
Show resolved
Hide resolved
Application toolkit document should update, and add an integration test case for this? |
ok |
doc and integration test case have added |
Here is the test report and validate logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document change suggestions inline.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
How to fix?
New feature or improvement