Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of JVM metrics handler and make ALS doc more accurate #5400

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

wu-sheng
Copy link
Member

Resolves #5394, and JVM metrics handler bugs reported by @peng-yongsheng

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! documentation Provide documents related issue or pull request only. backend OAP backend related. labels Aug 27, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Aug 27, 2020
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #5400 into master will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5400      +/-   ##
============================================
- Coverage     53.17%   53.01%   -0.16%     
+ Complexity     3219     3216       -3     
============================================
  Files           829      830       +1     
  Lines         20942    20981      +39     
  Branches       2036     2037       +1     
============================================
- Hits          11135    11124      -11     
- Misses         8899     8945      +46     
- Partials        908      912       +4     
Impacted Files Coverage Δ Complexity Δ
...ver/analyzer/provider/jvm/JVMSourceDispatcher.java 97.89% <100.00%> (ø) 17.00 <0.00> (ø)
.../analyzer/provider/meter/process/MeterBuilder.java 40.62% <0.00%> (-4.69%) 7.00% <0.00%> (ø%)
...nalyzer/provider/meter/process/MeterProcessor.java 57.62% <0.00%> (-3.39%) 13.00% <0.00%> (ø%)
...g/oap/server/telemetry/prometheus/BaseMetrics.java 86.66% <0.00%> (-3.34%) 8.00% <0.00%> (-1.00%)
...ng/oap/server/core/alarm/provider/RunningRule.java 45.90% <0.00%> (-1.82%) 11.00% <0.00%> (ø%)
...r/storage/plugin/influxdb/query/MetadataQuery.java 59.23% <0.00%> (-0.77%) 11.00% <0.00%> (-1.00%)
.../skywalking/amp/testcase/undertow/Application.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda4bbd...1b363d9. Read the comment docs.

Copy link
Member

@peng-yongsheng peng-yongsheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

@innerpeacez innerpeacez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALS doc. LGTM

@wu-sheng wu-sheng merged commit b11c351 into master Aug 27, 2020
@wu-sheng wu-sheng deleted the bug branch August 27, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug! documentation Provide documents related issue or pull request only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify the Observe service mesh through ALS steps in README
3 participants