Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin the process of SWIP - SkyWalking Improvement Proposal. #11668

Merged
merged 3 commits into from Dec 18, 2023
Merged

Begin the process of SWIP - SkyWalking Improvement Proposal. #11668

merged 3 commits into from Dec 18, 2023

Conversation

wu-sheng
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng wu-sheng added documentation Provide documents related issue or pull request only. backend OAP backend related. labels Dec 17, 2023
@wu-sheng wu-sheng added this to the 10.0.0 milestone Dec 17, 2023
wu-sheng
wu-sheng commented Dec 17, 2023
View reviewed changes
docs/en/swip/readme.md

## Known SWIPs

Next SWIP Number: 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use SWIP-1 for #11566

We have a consensus on this. @wankai123 @mrproliu As the new changes relative to #11566, you may need to update the SWIP-1 information.

@wu-sheng
Copy link
Member Author

FYI @apache/skywalking-committers Please comment if you have any concern.

hanahmily
hanahmily approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lujiajing1126
lujiajing1126 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@lujiajing1126 lujiajing1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 6304cd6 into master Dec 18, 2023
15 checks passed
@wu-sheng wu-sheng deleted the swip branch December 18, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanahmily hanahmily hanahmily approved these changes

@lujiajing1126 lujiajing1126 lujiajing1126 approved these changes

@mrproliu mrproliu mrproliu approved these changes

@wankai123 wankai123 wankai123 approved these changes

@liuhaoyang liuhaoyang Awaiting requested review from liuhaoyang

@kezhenxu94 kezhenxu94 Awaiting requested review from kezhenxu94

Assignees
No one assigned
Labels
backend OAP backend related. documentation Provide documents related issue or pull request only.
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wu-sheng @hanahmily @lujiajing1126 @mrproliu @wankai123