Support servlet 2.5 for Jetty,Tomcat,SpringMvc #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
added
agent
wu-sheng
reviewed
Jul 19, 2019
| @@ -42,4 +43,16 @@ public static String generateOperationName(Method method) { | |||
| operationName.append(")"); | |||
| return operationName.toString(); | |||
| } | |||
|
|
|||
|
|
|||
| public static boolean isGetStatusExist(ClassLoader classLoader) { | |||
There was a problem hiding this comment.
As an util, the class name should be parameter, right?
wu-sheng
reviewed
Jul 21, 2019
|
|
||
| public static boolean isMethodExist(ClassLoader classLoader, String className, String methodName, Class<?>... parameterTypes) { | ||
| try { | ||
| Class<?> httpServletResponse = Class.forName(className, true, classLoader); |
There was a problem hiding this comment.
Parameter type should be String if class name is string.
Add a comment to the new core util method. @candyleer I am concerning this method will be used widely even unnecessary.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
SpringMVC plugin not support servlet-api-2.5 #2975
Bug fix
Bug description.
How to fix?
New feature or improvement