Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support servlet 2.5 for Struts2 #4503

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Support servlet 2.5 for Struts2 #4503

merged 2 commits into from
Mar 13, 2020

Conversation

muyun12
Copy link
Contributor

@muyun12 muyun12 commented Mar 12, 2020 •
edited

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues
    PR#3120
    #2975

Bug fix

  • Bug description.

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.

@wu-sheng wu-sheng added this to the 7.0.0 milestone Mar 12, 2020
@wu-sheng wu-sheng added agent Language agent related. bug Something isn't working and you are sure it's a bug! plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Mar 12, 2020
wu-sheng
wu-sheng approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@candyleer Recheck, please.

@codecov-io
Copy link

Codecov Report

Merging #4503 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4503      +/-   ##
==========================================
- Coverage   25.55%   25.53%   -0.02%     
==========================================
  Files        1244     1244              
  Lines       28843    28845       +2     
  Branches     3944     3944              
==========================================
- Hits         7371     7366       -5     
- Misses      20794    20801       +7     
  Partials      678      678
Impacted Files Coverage Δ
...walking/apm/plugin/struts2/Struts2Interceptor.java 86.95% <66.66%> (+1.24%) ⬆️
...walking/oap/server/core/analysis/Downsampling.java 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb816c...488f77f. Read the comment docs.

candyleer
candyleer approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@candyleer candyleer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 80911d0 into apache:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@candyleer candyleer candyleer approved these changes

@ascrutae ascrutae Awaiting requested review from ascrutae

@arugal arugal Awaiting requested review from arugal

@kezhenxu94 kezhenxu94 Awaiting requested review from kezhenxu94

Assignees
No one assigned
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug! plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@muyun12 @codecov-io @wu-sheng @candyleer