-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/plugin autotest #3528
test/plugin autotest #3528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the following steps first.
- Make the license header clear. CI and e2e should pass.
- Provide a detailed document about how to develop the plugin.
- Provide document in development document about, how the plugin test works. give the potential contributor clear direction.
- Support plugin test scenarios in JVM and Tomcat, with or without docker-compose, such as Kafka, MySQL.
- Support parallel run tests in different VM(Jenkins), and have clear stage descriptions about which libraries tested in Jenkins UI.
…to test/plugin
The first case passed. Congrats, good start. You could remove |
This PR status looks good to me. @kezhenxu94 and @ascrutae please do final check, then we will run this again with right label, then prepare to merge. |
@kezhenxu94 After you approve, please open the jenkins test to run automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting for another approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @wu-sheng
We should start an issue to track existing plugin test cases immigration. |
After this PR, we are going to immigrate |
Submit two issues, let's tracke them. Then mysql with compose supportedv |
I will open an issue to track every plugin immigrated status later and open PR for |
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
[WIP] add agent test scenario for agent automatic test #2905
New feature or improvement
This PR works base on #2905 which @ascrutae does. The main purpose is to move the plugin-autotest back main repository.