Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/plugin autotest #3528

Merged
merged 35 commits into from
Oct 8, 2019
Merged

test/plugin autotest #3528

merged 35 commits into from
Oct 8, 2019

Conversation

dmsolr
Copy link
Member

@dmsolr dmsolr commented Sep 26, 2019

Please answer these questions before submitting pull request


New feature or improvement

  • Describe the details and related test reports.

This PR works base on #2905 which @ascrutae does. The main purpose is to move the plugin-autotest back main repository.

  1. There is a httpclient-scenario only here.
  2. I don't add this to Jenkins's stages yet.
  3. After this, I will add more scenarios for the tests.

@wu-sheng wu-sheng added this to the 6.5.0 milestone Sep 26, 2019
@wu-sheng wu-sheng added the test Test requirements about performance, feature or before release. label Sep 26, 2019
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the following steps first.

  1. Make the license header clear. CI and e2e should pass.
  2. Provide a detailed document about how to develop the plugin.
  3. Provide document in development document about, how the plugin test works. give the potential contributor clear direction.
  4. Support plugin test scenarios in JVM and Tomcat, with or without docker-compose, such as Kafka, MySQL.
  5. Support parallel run tests in different VM(Jenkins), and have clear stage descriptions about which libraries tested in Jenkins UI.

@wu-sheng wu-sheng added core feature Core and important feature. Sometimes, break backwards compatibility. agent Language agent related. CI settings CI settings adjustment documentation Provide documents related issue or pull request only. feature New feature labels Sep 27, 2019
@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2019

The first case passed. Congrats, good start. You could remove WIP of title, and let's polish this, and make it as an official step.

@dmsolr dmsolr changed the title [WIP]test/plugin autotest test/plugin autotest Oct 8, 2019
@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2019

This PR status looks good to me. @kezhenxu94 and @ascrutae please do final check, then we will run this again with right label, then prepare to merge.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2019

@kezhenxu94 After you approve, please open the jenkins test to run automatically.

wu-sheng
wu-sheng previously approved these changes Oct 8, 2019
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2019

Waiting for another approve.

@wu-sheng wu-sheng mentioned this pull request Oct 8, 2019
3 tasks
kezhenxu94
kezhenxu94 previously approved these changes Oct 8, 2019
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @wu-sheng

@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2019

We should start an issue to track existing plugin test cases immigration.

@dmsolr
Copy link
Member Author

dmsolr commented Oct 8, 2019

We should start an issue to track existing plugin test cases immigration.

After this PR, we are going to immigrate gson-plugin, jdk-plugin or both.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2019

Submit two issues, let's tracke them. Then mysql with compose supportedv

@dmsolr
Copy link
Member Author

dmsolr commented Oct 8, 2019

I will open an issue to track every plugin immigrated status later and open PR for compose.

@kezhenxu94 kezhenxu94 closed this Oct 8, 2019
@kezhenxu94 kezhenxu94 reopened this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. CI settings CI settings adjustment core feature Core and important feature. Sometimes, break backwards compatibility. documentation Provide documents related issue or pull request only. feature New feature test Test requirements about performance, feature or before release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants