Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Consul dynamic configuration center implementation #3560

Merged
merged 5 commits into from
Oct 5, 2019
Merged

Provide Consul dynamic configuration center implementation #3560

merged 5 commits into from
Oct 5, 2019

Conversation

kezhenxu94
Copy link
Member

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

resolves #2895

@kezhenxu94 kezhenxu94 added feature New feature backend OAP backend related. plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Oct 4, 2019
@kezhenxu94 kezhenxu94 added this to the 6.5.0 milestone Oct 4, 2019
wu-sheng
wu-sheng reviewed Oct 4, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend to add comments

docs/en/setup/backend/dynamic-config.md Outdated Show resolved Hide resolved
wu-sheng
wu-sheng approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should work on a document about all module/provider(s) and theiri configuration descriptions.

@kezhenxu94 kezhenxu94 merged commit 81f4c08 into apache:master Oct 5, 2019
@kezhenxu94 kezhenxu94 deleted the feature/dynamic-consul-impl branch October 5, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@zhaoyuguang zhaoyuguang Awaiting requested review from zhaoyuguang

Assignees
No one assigned
Labels
backend OAP backend related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

Dynamic Configuration Consul support
2 participants
@kezhenxu94 @wu-sheng