Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 5 places of using wrong Strings util #3582

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Fix 5 places of using wrong Strings util #3582

merged 2 commits into from
Oct 9, 2019

Conversation

wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Oct 9, 2019 •
edited

Fix 5 places of using wrong Strings util

@wu-sheng wu-sheng changed the title Exclude a dependency for test. Fix 5 places of using wrong Strings util Oct 9, 2019
@wu-sheng wu-sheng added the feature New feature label Oct 9, 2019
@wu-sheng wu-sheng added this to the 6.5.0 milestone Oct 9, 2019
kezhenxu94
kezhenxu94 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 3cdc1a1 into master Oct 9, 2019
@wu-sheng wu-sheng deleted the exp branch October 9, 2019 14:55
@wu-sheng wu-sheng mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wu-sheng @kezhenxu94