-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin]support log4j2 AsyncLogger #3715
Conversation
/run agent-plugin-test-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the document? And post the log when it actives?
@zhaoyuguang Could you check this locally? |
...kywalking/apm/toolkit/activation/log/log4j/v2/x/async/RingBufferLogEventInstrumentation.java
Outdated
Show resolved
Hide resolved
...walking/apm/toolkit/activation/log/log4j/v2/x/async/RingBufferLogEventMethodInterceptor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested locally that the log print TID is normal. So this pr is LGTM.
@wu-sheng @zhaoyuguang When I use |
There is no chance async logger could work. Unless we hijack the |
Please answer these questions before submitting pull request
Why submit this pull request?
[1 ] Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
there are 2 ways to implement Async log. but now this plugin just 1. so if i use Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector
to set async log . plugin doesn't work.
How to fix?
intercept RingBufferLogEvent.setMessage(), i can get traceId,then its ok.
New feature or improvement