Immigrate test mysql scenario. #3948

wayilau · 2019-11-27T07:24:06Z

Please answer these questions before submitting pull request

Why submit this pull request?
Bug fix
New feature provided
Improve performance
Tests cases.

wu-sheng · 2019-11-27T08:10:28Z

/run e2e

wu-sheng · 2019-11-27T08:59:01Z

@wayilau Send a mail to your cmss mailbox, please check.

wayilau · 2019-11-27T09:14:08Z

@wayilau Send a mail to your cmss mailbox, please check.

@wu-sheng I received message you just wrote.

dmsolr

Make it works and then update the elapsed time of the document. :)

dmsolr · 2019-11-27T11:38:24Z

test/plugin/scenarios/mysql-scenario/config/expectedData.yaml

+  instances:
+    - {mysql-scenario: 1}
+  operationNames:
+    - mysql-scenario: [/mysql-scenario/case/mysql]


Are you missing some operatioName? For example, /JDBI/statement/execute.

I will copy it from original source.

Jenkinsfile-Agent-Test-3

arugal · 2019-11-27T15:22:01Z

Ref #3583

arugal · 2019-11-27T15:31:45Z

Hi, I have a question, what do we not use JVM-container？

wayilau · 2019-11-28T09:31:04Z

Hi, I have a question, what do we not use JVM-container？

original tests cases use tomcat, so i follow. @arugal

wu-sheng · 2019-11-28T13:32:42Z

Jenkins jobs have been disabled, please add your tasks to GitHub action file, and fix the conflict, remove the Jenkins file. https://github.com/apache/skywalking/blob/master/.github/workflows/plugins-test.yaml

wayilau · 2019-11-28T14:06:52Z

Jenkins jobs have been disabled, please add your tasks to GitHub action file, and fix the conflict, remove the Jenkins file. https://github.com/apache/skywalking/blob/master/.github/workflows/plugins-test.yaml

ok.

wayilau · 2019-11-28T17:44:05Z

Hi, I have a question, what do we not use JVM-container？

original tests cases use tomcat, so i follow. @arugal

As I have moved to JVM container. Beacause tomcat met some problems.

dmsolr · 2019-11-29T02:29:17Z

It is very sad to tell you that you need to update the Action configuration (resolve conflicts) because those are updated after #3956 merged. Maybe you need to move it to another group which is faster.
And the test failed (Tomcat-container doesn't need to pack it as a ZIP package. )

wayilau · 2019-11-29T16:21:29Z

It is very sad to tell you that you need to update the Action configuration (resolve conflicts) because those are updated after #3956 merged. Maybe you need to move it to another group which is faster.
And the test failed (Tomcat-container doesn't need to pack it as a ZIP package. )

ok, I am using jVM container. May be i lost some files. i will check then submit again.

wu-sheng · 2019-11-30T00:00:01Z

Jenkins is not there any more. We are working out with Apache why those are still there.

wu-sheng · 2019-11-30T00:00:50Z

You should add MySQL As a separated group in that test case, named As MySQL case like others.

wayilau · 2019-11-30T07:07:44Z

You should add MySQL As a separated group in that test case, named As MySQL case like others.

ok

codecov-io · 2019-11-30T07:44:14Z

Codecov Report

Merging #3948 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3948   +/-   ##
======================================
  Coverage    27.9%   27.9%           
======================================
  Files        1122    1122           
  Lines       24341   24341           
  Branches     3528    3528           
======================================
  Hits         6792    6792           
  Misses      16949   16949           
  Partials      600     600

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc0609...c3b30d4. Read the comment docs.

wu-sheng · 2019-11-30T08:41:51Z

What is PluginsTest / .github/workflows/plugins-test.yaml (pull_request)?

wu-sheng · 2019-11-30T08:42:54Z

.github/workflows/plugins-test.yaml

+        run: bash test/plugin/run.sh kafka-scenario
+
+Mysql:


This is not a correct format, This is a YAML.

The indentation is not correct IMO, syntax looks good

dmsolr · 2019-11-30T11:49:07Z

It still fails. Please recheck.

wayilau · 2019-11-30T11:49:57Z

Log tells me that docker startup failed. I don't know why. Could you help me check ? @dmsolr

wu-sheng · 2019-11-30T11:55:00Z

@wayilau I think it was caused by the wrong YAML format. Has been fixed. Now, you need to make your tests passed.

wayilau · 2019-11-30T11:59:53Z

@wayilau I think it was caused by the wrong YAML format. Has been fixed. Now, you need to make your tests passed.

I think i know why. I missed some commits.

dmsolr · 2019-11-30T12:16:46Z

It looks like good.
Let's wait for this result. :)

dmsolr

LGTM

wu-sheng

LGTM. 53 MySQL Cases, crazy...

wu-sheng · 2019-11-30T13:01:33Z

@wayilau I don't get any reply from you about the mail. Are you planning to do?

wayilau · 2019-11-30T13:52:46Z

@wayilau I don't get any reply from you about the mail. Are you planning to do?

@wu-sheng
I did not receive any emails from you yet. So i don't understand ..

wu-sheng · 2019-11-30T13:55:27Z

Could you send a mail to me? I send you a mail based on your GitHub homepage mail, maybe it is incorrect? Mind is correct, you could send a mail to there.

wayilau · 2019-11-30T14:01:12Z

Could you send a mail to me? I send you a mail based on your GitHub homepage mail, maybe it is incorrect? Mind is correct, you could send a mail to there.

I am sorry, i just saw mail from my rubbish mail box. May be the mail settings is limit by the commany. I will read the mail first. @wu-sheng

wayilau added 4 commits November 25, 2019 13:57

Add mysql scenario

70d2d6f

Update mysql scenario.

2bdc87f

Merge branch 'master' into dev3

0096807

Update jenkin's config.

42e26bd

wu-sheng requested review from arugal and dmsolr November 27, 2019 07:24

wayilau and others added 2 commits November 27, 2019 15:25

Modify jenkin's config.

da06a75

Merge branch 'master' into dev3

133b35c

wu-sheng added feature New feature test Test requirements about performance, feature or before release. labels Nov 27, 2019

wu-sheng added this to the 6.6.0 milestone Nov 27, 2019

Merge branch 'dev3' of github.com:wayilau/skywalking into dev3

e0012d7

dmsolr reviewed Nov 27, 2019

View reviewed changes

wayilau added 3 commits November 29, 2019 01:31

Fix CI failed && move to JVM container.

828b034

Merge master to dev3

a0d267a

update plugin-test.yaml for tests.

76f5763

Merge branch 'master' into dev3

10e9316

Update plugins-test for mysql.

4500ad7

wu-sheng reviewed Nov 30, 2019

View reviewed changes

wayilau added 2 commits November 30, 2019 18:04

Fix format.

95d5924

Fix missed assembly.yml.

5a28880

Add missed Javafiles.

c3b30d4

dmsolr approved these changes Nov 30, 2019

View reviewed changes

wu-sheng approved these changes Nov 30, 2019

View reviewed changes

wu-sheng merged commit c0c898c into apache:master Nov 30, 2019

wayilau deleted the dev3 branch November 30, 2019 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Immigrate test mysql scenario. #3948

Immigrate test mysql scenario. #3948

wayilau commented Nov 27, 2019

wu-sheng commented Nov 27, 2019

wu-sheng commented Nov 27, 2019

wayilau commented Nov 27, 2019

dmsolr left a comment

dmsolr Nov 27, 2019

wayilau Nov 28, 2019

arugal commented Nov 27, 2019

arugal commented Nov 27, 2019

wayilau commented Nov 28, 2019

wu-sheng commented Nov 28, 2019

wayilau commented Nov 28, 2019

wayilau commented Nov 28, 2019

dmsolr commented Nov 29, 2019

wayilau commented Nov 29, 2019

wu-sheng commented Nov 30, 2019

wu-sheng commented Nov 30, 2019

wayilau commented Nov 30, 2019

codecov-io commented Nov 30, 2019 •

edited

Loading

wu-sheng commented Nov 30, 2019

wu-sheng Nov 30, 2019

kezhenxu94 Nov 30, 2019

dmsolr commented Nov 30, 2019

wayilau commented Nov 30, 2019 •

edited

Loading

wu-sheng commented Nov 30, 2019

wayilau commented Nov 30, 2019

dmsolr commented Nov 30, 2019

dmsolr left a comment

wu-sheng left a comment

wu-sheng commented Nov 30, 2019

wayilau commented Nov 30, 2019

wu-sheng commented Nov 30, 2019

wayilau commented Nov 30, 2019

Immigrate test mysql scenario. #3948

Immigrate test mysql scenario. #3948

Conversation

wayilau commented Nov 27, 2019

wu-sheng commented Nov 27, 2019

wu-sheng commented Nov 27, 2019

wayilau commented Nov 27, 2019

dmsolr left a comment

Choose a reason for hiding this comment

dmsolr Nov 27, 2019

Choose a reason for hiding this comment

wayilau Nov 28, 2019

Choose a reason for hiding this comment

arugal commented Nov 27, 2019

arugal commented Nov 27, 2019

wayilau commented Nov 28, 2019

wu-sheng commented Nov 28, 2019

wayilau commented Nov 28, 2019

wayilau commented Nov 28, 2019

dmsolr commented Nov 29, 2019

wayilau commented Nov 29, 2019

wu-sheng commented Nov 30, 2019

wu-sheng commented Nov 30, 2019

wayilau commented Nov 30, 2019

codecov-io commented Nov 30, 2019 • edited Loading

Codecov Report

wu-sheng commented Nov 30, 2019

wu-sheng Nov 30, 2019

Choose a reason for hiding this comment

kezhenxu94 Nov 30, 2019

Choose a reason for hiding this comment

dmsolr commented Nov 30, 2019

wayilau commented Nov 30, 2019 • edited Loading

wu-sheng commented Nov 30, 2019

wayilau commented Nov 30, 2019

dmsolr commented Nov 30, 2019

dmsolr left a comment

Choose a reason for hiding this comment

wu-sheng left a comment

Choose a reason for hiding this comment

wu-sheng commented Nov 30, 2019

wayilau commented Nov 30, 2019

wu-sheng commented Nov 30, 2019

wayilau commented Nov 30, 2019

codecov-io commented Nov 30, 2019 •

edited

Loading

wayilau commented Nov 30, 2019 •

edited

Loading