Skip to content

Remove nacos#4867

Merged
rainbend merged 32 commits intoapache:masterfrom
songzhendong:removenacos
Jun 6, 2020
Merged

Remove nacos#4867
rainbend merged 32 commits intoapache:masterfrom
songzhendong:removenacos

Conversation

@songzhendong
Copy link
Copy Markdown
Contributor

@songzhendong songzhendong commented Jun 6, 2020

Remove nacos

songzhendong and others added 30 commits April 24, 2020 15:31
@songzhendong
Merge pull request #2 from apache/master
750b42d 
update
Add annotation(AlarmCore.start)
b1cbcfe
Merge remote-tracking branch 'upstream/master'
1a148e8
Merge branch 'master' of https://github.com/songzhendong/skywalking
8bccff2
Upgrade nacos version to 1.2.0
4d7b06f
Revert "Upgrade nacos version to 1.2.0"
d2ee843 
This reverts commit 4d7b06f.
Merge branch 'master' of https://github.com/apache/skywalking
8224a90
Update nacos version to 1.2.0(Solve the security problem of the old v…
63b1160 
…ersion of fastsjon)
Recovery annotation
b2facaf
Recovery annotation
9b408dc
Update nacos version to 1.2.0
bf5d138
@songzhendong
Update tls_key_generate.sh path
409984e 
Update tls_key_generate.sh path
Add annotation(AlarmCore.start)
0103668
Revert "Upgrade nacos version to 1.2.0"
c646395 
This reverts commit 4d7b06f.
Update nacos version to 1.2.0(Solve the security problem of the old v…
1f51d78 
…ersion of fastsjon)
Recovery annotation
b9aa6ed
Recovery annotation
964aa8c
Update tls_key_generate.sh path
f47fae6
Merge branch 'master' of https://github.com/songzhendong/skywalking
c65ae76
Execution Authority
8f41446
@songzhendong
Merge branch 'master' into master
61a7d2d
@wu-sheng
Merge branch 'master' into master
7db7fa9
@songzhendong
Merge remote-tracking branch 'upstream/master'
04d6330
@songzhendong
Merge remote-tracking branch 'upstream/master' into dev
2d0e62c
@songzhendong
Remove nacos
9b6a4a2
@songzhendong
remove nacos code
354ec5b
@songzhendong
remove nacos
d1b99fd 
remove nacos
@songzhendong
remove nacos
0862826 
remove nacos
@songzhendong
remove nacos
2c95457
@songzhendong
modify md
51fa549
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2020 •
edited
Loading

Codecov Report

Merging #4867 into master will increase coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4867      +/-   ##
============================================
+ Coverage     50.50%   51.14%   +0.63%     
+ Complexity     2754     2745       -9     
============================================
  Files           757     1330     +573     
  Lines         18670    28920   +10250     
  Branches       1808     3157    +1349     
============================================
+ Hits           9430    14790    +5360     
- Misses         8491    13451    +4960     
+ Partials        749      679      -70
Impacted Files Coverage Δ Complexity Δ
...erver/receiver/envoy/MetricServiceGRPCHandler.java 12.16% <0.00%> (-77.84%) 2.00% <0.00%> (ø%)
...er/receiver/envoy/AccessLogServiceGRPCHandler.java 20.75% <0.00%> (-37.15%) 2.00% <0.00%> (ø%)
...skywalking/oap/server/core/alarm/AlarmMessage.java 66.66% <0.00%> (-33.34%) 2.00% <0.00%> (ø%)
...prometheus/provider/PrometheusFetcherProvider.java 32.25% <0.00%> (-30.25%) 8.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchInsertRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchUpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...r/cluster/plugin/standalone/StandaloneManager.java 80.00% <0.00%> (-20.00%) 3.00% <0.00%> (-1.00%)
...ticsearch7/client/ElasticSearch7UpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ticsearch7/client/ElasticSearch7InsertRequest.java 83.33% <0.00%> (-16.67%) 2.00% <0.00%> (ø%)
...erver/core/analysis/data/MergableBufferedData.java 84.61% <0.00%> (-15.39%) 4.00% <0.00%> (ø%)
... and 891 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305a6b3...3d4c7af. Read the comment docs.

@songzhendong
Copy link
Copy Markdown
Contributor Author

songzhendong commented Jun 6, 2020

Temporarily remove Nacos(After Nacos is stable, it will be re integrated into skywalking)

wu-sheng
wu-sheng approved these changes Jun 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @apache/skywalking-committers We have made decision in ml, please confirm and comment if there is objection.

@wu-sheng wu-sheng requested a review from a team June 6, 2020 01:42
@wu-sheng wu-sheng added this to the 8.0.0 milestone Jun 6, 2020
@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! high priority High priority issue, blocking next release. labels Jun 6, 2020
@rainbend rainbend merged commit f3d907b into apache:master Jun 6, 2020
@kezhenxu94
Copy link
Copy Markdown
Member

kezhenxu94 commented Jun 6, 2020

@arugal please rewrite the commit message when merging, there're too long/many useless message

image

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Jun 6, 2020

@arugal Please pay attention to this. In the commit logs are too many and don't have much meaning. Please consider to edit and remove all.

@rainbend
Copy link
Copy Markdown
Member

rainbend commented Jun 6, 2020

@kezhenxu94 @wu-sheng I will pay attention in the future. Thank you for reminding me :)

dagmom pushed a commit to brains-platform/skywalking that referenced this pull request Jun 6, 2020
@songzhendong @wu-sheng @dagmom
Remove nacos (apache#4867)
fa94bb5 
* Add annotation(AlarmCore.start)

* Upgrade nacos version to 1.2.0

* Revert "Upgrade nacos version to 1.2.0"

This reverts commit 4d7b06f.

* Update nacos version to 1.2.0(Solve the security problem of the old version of fastsjon)

* Recovery annotation

* Recovery annotation

* Update nacos version to 1.2.0

* Update tls_key_generate.sh path

Update tls_key_generate.sh path

* Add annotation(AlarmCore.start)

* Revert "Upgrade nacos version to 1.2.0"

This reverts commit 4d7b06f.

* Update nacos version to 1.2.0(Solve the security problem of the old version of fastsjon)

* Recovery annotation

* Recovery annotation

* Update tls_key_generate.sh path

* Execution Authority

* Remove nacos

* remove nacos code

* remove nacos

remove nacos

* remove nacos

remove nacos

* remove nacos

* remove nacos

Co-authored-by: songzhendong <289505773@qq.com>
Co-authored-by: songzhendong <songzhendong@xiaomi.com>
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
@songzhendong songzhendong mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@moonming moonming moonming approved these changes

Assignees

No one assigned

Labels

bug Something isn't working and you are sure it's a bug! high priority High priority issue, blocking next release.

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@songzhendong @kezhenxu94 @wu-sheng @rainbend @moonming