support rocket mq plugin #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.2%) to 18.142% when pulling 51b6d906b35333dcc01f630b851def423608cae0 on ascrutae:feature/support-rocketMQ-plugin into a1276c8 on OpenSkywalking:master. |
wu-sheng
requested changes
Nov 5, 2017
There was a problem hiding this comment.
The operation should be
RocketMQ/TopicName/Producer/...RocketMQ/TopicName/Producer/Callback/...RocketMQ/TopicName/Consumer/...
And this pull request depends on some UI adjustments:
- Support MQ in Topological graph [UI][Collector] Support MQ in Topological graph #572
- Support TraceSegment batch merge(MQ) in trace stack detail [UI] Support TraceSegment batch merge(MQ) in trace stack detail #573
FYI @peng-yongsheng This pr effects collector side too, although it is only a plugin.
|
I had changed the operation name and pull the snapshots of trace segment |
ascrutae
force-pushed
the
feature/support-rocketMQ-plugin
branch
from
51b6d90
to
30dbdc8
Compare
|
@ascrutae You are facing a conflict. |
|
@ascrutae Since PMC has decided to move on 5.x , @hanahmily will lead the new UI, so I will merge this as a provided plugin. |
Merged
ascrutae
force-pushed
the
feature/support-rocketMQ-plugin
branch
from
5e67f93
to
6bc41c0
Compare
ascrutae
force-pushed
the
feature/support-rocketMQ-plugin
branch
from
6bc41c0
to
1fa8178
Compare
wu-sheng
approved these changes
Dec 4, 2017
lu-xiaoshuang
pushed a commit
to lu-xiaoshuang/skywalking
that referenced
this pull request
Aug 12, 2024
Co-authored-by: 熊哲源 <xiongzheyuan@shouqianba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the sync call:
Here is the async call:
