SLING-7529 - implemented layout inheritance in log encoder #3
Conversation
|
Looks fine. Can you add a test case for the same |
…y; minor fix in how categories are matched
|
@chetanmeh I've added some simple JUnit tests as well as fixed one conrnercase where loggers for similarly-named packages might end up using wrong layouts - probably wouldn't occur in AEM setup, but it theoretically can happen and thus is a bug - I've added a test case for it as well. If the code is ok as-is, then please let me know if it would be possible to release it soon as 5.1.3, otherwise please let me know your thoughts on the code. Cheers |
|
@chetanmeh : any chance you could find some time to take a look at the update to this PR? |
|
@CptBartender Sorry for the delay here. Would look into this early next week |
|
@CptBartender Can you add license headers on the newly added files in test. Without that build fails for |
|
@chetanmeh I've added the requested headers |
I've implemented a simple method that finds the best (longest) match among the registered layouts and put it in place of the //TODO tag within the code.
I did not run the tests as these don't pass on my environment for unrelated reasons, however the class is not mentioned in any tests so I'm assuming this shouldn't break existing tests.