Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-7358: FileDistributionPackageBuilder temp directory fallback #1

Merged
merged 3 commits into from
Jan 8, 2018

Conversation

buuhuu
Copy link
Member

@buuhuu buuhuu commented Jan 7, 2018

fallback to jvm's default temp directory if not configured in FileDistributionPackageBuilder

@tteofili
Copy link
Contributor

tteofili commented Jan 8, 2018

the PR looks good to me, except the Apache License header in FileDistributionPackageBuilderTest is missing (mvn clean install fails).

@buuhuu
Copy link
Member Author

buuhuu commented Jan 8, 2018

I added the missing header.

@tteofili tteofili merged commit 36c7bf8 into apache:master Jan 8, 2018
@tteofili
Copy link
Contributor

tteofili commented Jan 8, 2018

thanks @buuhuu for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants