SLING-8869 SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

[mohiaror]

Do not set the default authorization header at the time of creating the executor but delegate this responsibility to the issuer of the request such that everytime POST request is made, if the executor is token based, check for the expiry of the token and add the relevant header to the request.

[tmaret]

@mohiaror it seems that Sonar is correct here, DistributionTransportSecret#getAuthSecret may return null as documented in the API. Could you please add a null check ?

[tmaret]

The PR should handle null returned by DistributionTransportSecret#asCredentialsMap

[mohiaror]

@tmaret

it seems that Sonar is correct here, DistributionTransportSecret#getAuthSecret may return null as documented in the API.

The PR should handle null returned by DistributionTransportSecret#asCredentialsMap

We are already checking the null occurrence of DistributionTransportSecret#asCredentialsMap in the code. The sonar report is actually showing the NPE for secret returned by DistributionTransportSecretProvider#getSecret Line#235 which is old code and I assume this error must have been coming in previous reports as well. Nevertheless, I will add a patch for that in the PR.

[mohiaror]

@tmaret

I assume this error must have been coming in previous reports as well.

Looking at the sonar report [0], it indeed is a 2 years old bug. Nevertheless, I have added the patch with commit 49e8f9c. Kindly review.

[0] https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-core&pullRequest=28&resolved=false&types=BUG