SLING-7359: prevent distribution loop in triggers from distribution events #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2018 15:15
|
sorry, it was my mistake not having rebased PR #2 when merging it. I'll fix it and then we can apply this PR. |
added 2 commits
January 9, 2018 11:14
|
I updated the PR already |
|
thanks @buuhuu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by exposing information of the trigger.DispatcherRequestHandler to the trigger implementations, which allow them to filter events they are handling. The DistributionEventDistributeDistributionTrigger has been changed to not propagate events to the handler which have there origin at the handler's owner itself.