SLING-7357: set content type to forward distrib http headers #2
Conversation
|
the patch looks good to me. |
|
It's more about a functional requirement when integrating into systems that offer a http API that uses content negotiation to determine how to handle the content. In my specific example, integrating into solr its the JsonLoader that is supposed to be used for application/json. Though this is incomplete until SLING-7364 gets resolved because the binary stream is modified outside of the serializers scope (adding DistributionPackageInfo as binary header in front of the content) |
|
ok, thanks for the clarification. For SLING-7364 you can look into https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/packaging/impl/AbstractDistributionPackageBuilder.java#L81. Other than that the patch looks good to me, thanks! |
* the deleted annotation _seems to be_ the only line marked 'duplicate' in the new code. This is definitely not the right thing to do, but adding this commit just to see if the real problem lies somewhere else
Added content type to be specified by the DistributionContentSerializer and DistributionPackageBuilder.
This is a major change of org.apache.sling.distribution.serialization.