SLING-8419 write back configuration in OSGi JSON format #2
Conversation
kwin
force-pushed
the
feature/json-config-writeback
branch
from
13588e8
to
299a71e
Compare
| } | ||
|
|
||
| try (OutputStream fos = new BufferedOutputStream(new FileOutputStream(file))) { | ||
| fos.write("# Configuration created by Apache Sling File Installer\n".getBytes(StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
I’m not sure the # character introduces a valid comment in JSON…
Then again https://sling.apache.org/documentation/bundles/configuration-installer-factory.html mentions being allowed to use // comments, which also would not be valid JSON…
There was a problem hiding this comment.
The first issue was reported and solved in the context of https://issues.apache.org/jira/browse/SLING-9218.
Comments are allowed though, as specified in https://osgi.org/specification/osgi.cmpn/7.0.0/service.configurator.html#d0e131566:
Comments in the form of [2] JSMin (The JavaScript Minifier) comments are supported, that is, any text on the same line after // is ignored and any text between /* */ is ignored.
In any case this PR has already been merged. If you find any issue feel free to report it via https://issues.apache.org/jira/browse/SLING!
No description provided.