SLING-11621: Update JCR dependencies #39
Conversation
pom.xml
Outdated
| @@ -36,8 +36,8 @@ | |||
| </description> | |||
|
|
|||
| <properties> | |||
| <jackrabbit.version>2.18.2</jackrabbit.version> | |||
| <oak.version>1.22.1</oak.version> | |||
| <jackrabbit.version>2.20.6</jackrabbit.version> | |||
There was a problem hiding this comment.
AEM 6.5(.15) is still on 2.20.4, but if it is semantically versioned that shouldn't matter....
There was a problem hiding this comment.
@reschke Please don't resolve without commenting or fixing. Why should we depend at compile time on a newer version than at run time? This IMHO calls for trouble. In general the policy of Sling is stated in https://cwiki.apache.org/confluence/display/SLING/Dependabot.
There was a problem hiding this comment.
I don't think that comment was actionable.
|
@reschke the build fails now due to a missing dependency (was probably transitively inherited before). |
… import jetbrains annotations
|
Dependencies should be complete and correct now. Sorry for the inconvenience. I still have test failures, but those occur on master as well and are likely platform dependant. Will investigate. |
SLING-11737: jcr-repoinit - fix test failures on Windows (apache#42)
|
Ok, will have a look. |
|
The issue seems to be caused by those ITs trying to bind to jackrabbit artefacts (like rmi) that are not present with the version number being asked for. I assume these come in somehow as transitive dependencies, but I haven't figured out yet, how. It probably would be better to first upgrade the testing dependencies to current Jackrabbit/Oak versions so we don't have to worry about these. |
No description provided.