-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLING-11621: Update JCR dependencies #39
base: master
Are you sure you want to change the base?
Conversation
pom.xml
Outdated
@@ -36,8 +36,8 @@ | |||
</description> | |||
|
|||
<properties> | |||
<jackrabbit.version>2.18.2</jackrabbit.version> | |||
<oak.version>1.22.1</oak.version> | |||
<jackrabbit.version>2.20.6</jackrabbit.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AEM 6.5(.15) is still on 2.20.4, but if it is semantically versioned that shouldn't matter....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reschke Please don't resolve without commenting or fixing. Why should we depend at compile time on a newer version than at run time? This IMHO calls for trouble. In general the policy of Sling is stated in https://cwiki.apache.org/confluence/display/SLING/Dependabot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that comment was actionable.
@reschke the build fails now due to a missing dependency (was probably transitively inherited before). |
… import jetbrains annotations
Dependencies should be complete and correct now. Sorry for the inconvenience. I still have test failures, but those occur on master as well and are likely platform dependant. Will investigate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces IT test failures with pax-exam.
SLING-11737: jcr-repoinit - fix test failures on Windows (apache#42)
Ok, will have a look. |
The issue seems to be caused by those ITs trying to bind to jackrabbit artefacts (like rmi) that are not present with the version number being asked for. I assume these come in somehow as transitive dependencies, but I haven't figured out yet, how. It probably would be better to first upgrade the testing dependencies to current Jackrabbit/Oak versions so we don't have to worry about these. |
No description provided.