SLING-12329 - Backwards compatibility for legacy repoinit statement reordering #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerghoh
reviewed
May 28, 2024
| }); | ||
| } catch (RepoInitException originalFailure) { | ||
| // support legacy statement reordering for backwards compatibility | ||
| try { |
There was a problem hiding this comment.
can you please extract this complete section into a dedicated method?
| } | ||
| } | ||
|
|
||
| log.warn("DEPRECATION - The repoinit script being executed relies on a bug causing repoinit " + |
There was a problem hiding this comment.
Do we have a Jira ID or something we can reference when it comes to fixing? This warning is hardly actionable for anyone not familiar with repoinit.
There was a problem hiding this comment.
Not sure if SLING-12107 helps. That is the ticket where the "new" ordering was introduced.
We also don't have enough context to explain what the issue is. However, it may be worthwhile including the originalFailure exception, or at least its message, in the log message.
joerghoh
reviewed
May 28, 2024
…eordering - address PR feedback
…eordering - state that repoinit was successful in legacy mode
joerghoh
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.