-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLING-12329 - Backwards compatibility for legacy repoinit statement reordering #54
Conversation
}); | ||
} catch (RepoInitException originalFailure) { | ||
// support legacy statement reordering for backwards compatibility | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please extract this complete section into a dedicated method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
} | ||
} | ||
|
||
log.warn("DEPRECATION - The repoinit script being executed relies on a bug causing repoinit " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a Jira ID or something we can reference when it comes to fixing? This warning is hardly actionable for anyone not familiar with repoinit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if SLING-12107 helps. That is the ticket where the "new" ordering was introduced.
We also don't have enough context to explain what the issue is. However, it may be worthwhile including the originalFailure
exception, or at least its message, in the log message.
…eordering - address PR feedback
…eordering - state that repoinit was successful in legacy mode
No description provided.