Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLING-9364: Implement lazy response writer #2

Merged
merged 5 commits into from
Apr 14, 2020
Merged

SLING-9364: Implement lazy response writer #2

merged 5 commits into from
Apr 14, 2020

Conversation

karlpauls
Copy link
Contributor

No description provided.

raducotescu
raducotescu reviewed Apr 14, 2020
View reviewed changes
Copy link
Member

@raducotescu raducotescu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting aside, these two classes are not used. Shouldn't they be wired either in the ScriptContextProvider or in the BundledScriptServlet?

@karlpauls
Copy link
Contributor Author

@raducotescu, yes, ofcourse - PTAL (forgot to add the change to use it in the bindings).

@raducotescu
SLING-9364 - Implement lazy response writer
0b564ef 
* made formatting consistent
* corrected typo in variable name
@raducotescu raducotescu merged commit 6c5b2ed into master Apr 14, 2020
@raducotescu raducotescu deleted the issues/SLING-9364 branch April 14, 2020 08:13
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducotescu raducotescu raducotescu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlpauls @raducotescu