Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLING-12002 Discard "special logging" to stdout from ESAPI #29

Merged
merged 2 commits into from
Aug 15, 2023
Merged

SLING-12002 Discard "special logging" to stdout from ESAPI #29

merged 2 commits into from
Aug 15, 2023

Conversation

stefanseifert
Copy link
Member

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.16.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

rombert
rombert approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@rombert rombert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You could maybe set it only if not already set to allow for debugging, or print a message once so that the users know we are meddling with it. But they probably don't care :-)

@stefanseifert
Copy link
Member Author

lets keep it simple for now...

@stefanseifert stefanseifert merged commit 7a8706a into master Aug 15, 2023
2 checks passed
@stefanseifert stefanseifert deleted the feature/SLING-12002-esapi-discard-stdout branch August 15, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rombert rombert rombert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanseifert @rombert