SLING-11291 make use of bnd:jar goal #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move bnd plugin configuration out of executions section to apply it to both executions
|
Kudos, SonarCloud Quality Gate passed!
|
kwin
requested changes
Apr 29, 2022
There was a problem hiding this comment.
As outlined in the JIRA I don't think we should change the packaging goal. Let's use each plugin for what it was designed. Not using m-j-p for doing the packaging may lead to introducing vulnerabilities. m-j-p is by far the most popular packaging plugin and well maintained.
| </goals> | ||
| </execution> | ||
| <execution> | ||
| <id>bnd-jar</id> |
There was a problem hiding this comment.
bnd:jar encapsulates generating metadata and therefore OSGi metadata is generated twice in mvn package which seems quite some overhead
|
abandoned as discussed in https://issues.apache.org/jira/browse/SLING-11291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move bnd plugin configuration out of executions section to apply it to both executions
see also discussion in https://issues.apache.org/jira/browse/SLING-11291