Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-11291 make use of bnd:jar goal #24

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
35 changes: 17 additions & 18 deletions sling-bundle-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,9 @@
<groupId>biz.aQute.bnd</groupId>
<artifactId>bnd-maven-plugin</artifactId>
<version>${bnd.version}</version>
<executions>
<execution>
<id>bnd-process</id>
<goals>
<goal>bnd-process</goal>
</goals>
<configuration>
<bnd><![CDATA[
<extensions>true</extensions>
<configuration>
<bnd><![CDATA[
# a lot of bundle header are generated from pom elements by default: https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin#default-bundle-headers
Bundle-Category: sling

Expand All @@ -82,8 +77,20 @@ Bundle-DocURL: https://sling.apache.org
-fixupmessages:"Export *, has \\d+, private references"; \
restrict:=warning; \
is:=error
]]></bnd>
</configuration>
]]></bnd>
</configuration>
<executions>
<execution>
<id>bnd-process</id>
<goals>
<goal>bnd-process</goal>
</goals>
</execution>
<execution>
<id>bnd-jar</id>
Copy link
Member

@kwin kwin Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bnd:jar encapsulates generating metadata and therefore OSGi metadata is generated twice in mvn package which seems quite some overhead

<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>
Expand All @@ -108,14 +115,6 @@ Bundle-DocURL: https://sling.apache.org
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
</archive>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>
Expand Down