Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15600 Move powered by to sub page, skip logos #36

Merged
merged 7 commits into from
Aug 31, 2021
Merged

SOLR-15600 Move powered by to sub page, skip logos #36

merged 7 commits into from
Aug 31, 2021

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Aug 27, 2021

Also skiping Sears, IBM Websphere Commerce and The Echo Nest due to jira comments

There is no styling in this 1st step, focus is to get into compliance with policies and remove known false claims.

A 2nd phase can be to gather new testimonials and logos and to do some styling etc. This is how it will look on the front page
Skjermbilde 2021-08-27 kl  15 46 26

And this is how the powered-by list in its first incarnation will be (ugly, I know)
Skjermbilde 2021-08-27 kl  15 46 36

(I tried copying over the HTML and styling but it does not work on that sub page, so reverted to plain MD.)

Also skiping Sears, IBM Websphere Commerce and The Echo Nest due to jira comments
content/pages/community.md Outdated Show resolved Hide resolved
themes/solr/templates/index.html Outdated Show resolved Hide resolved
themes/solr/templates/index.html Show resolved Hide resolved
@HoustonPutman
Copy link
Contributor

Are we getting rid of the logos for compliance, or just to make migration easier?

@HoustonPutman
Copy link
Contributor

I made changes so that we can merely maintain a list, and the table is auto-formatted.

The logo slider also works, but I've commented it out until I'm clear whether it's being removed for compliance reasons.

Could you allow me to push to the PR? It's saying I don't have permission.

@cpoerschke
Copy link
Contributor

Could you allow me to push to the PR? It's saying I don't have permission.

Maybe be same as apache/solr#99 (comment) in May?

@HoustonPutman
Copy link
Contributor

Could you allow me to push to the PR? It's saying I don't have permission.

Maybe be same as apache/solr#99 (comment) in May?

Ahhh that's probably it. Unfortunate

@cpoerschke
Copy link
Contributor

Could you allow me to push to the PR? It's saying I don't have permission.

Maybe be same as apache/solr#99 (comment) in May?

Ahhh that's probably it. Unfortunate

Perhaps unusual but you could probably open a pull request for the cominvent:move-logos branch i.e. a pull request to a pull request. Or push your changes to branch on your fork and @janhoy could merge or cherry-pick from there. And maybe there's another way also, so many options with git ...

janhoy and others added 3 commits August 27, 2021 20:39
@janhoy
Copy link
Contributor Author

janhoy commented Aug 27, 2021

@HoustonPutman feel free to open a PR against my branch with whatever you have. I did not see your feedback until I already removed logos and sorted the list alphabetically. If you have the bandwidth to get us a nicer layout in this first iteration it would be superb!

@janhoy
Copy link
Contributor Author

janhoy commented Aug 27, 2021

Are we getting rid of the logos for compliance, or just to make migration easier?

Main goal is to move the logos/names away from front-page. We are allowed to use logos on the sub page, but I guess since there was some uncertainty about whether they are still correct, it may be better to start with a list, and then add logos as we get confirmations from each user.

If you have a trick to make that logo slider easier to maintain that is not wasted.

@HoustonPutman
Copy link
Contributor

Make poweredby list easy and organized
@janhoy
Copy link
Contributor Author

janhoy commented Aug 27, 2021

PR Opened: cominvent#1

Thanks Houston. Merged.

content/pages/community.md Outdated Show resolved Hide resolved
Co-authored-by: David Smiley <dsmiley@apache.org>
@janhoy janhoy merged commit bab41fa into apache:main Aug 31, 2021
@janhoy janhoy deleted the move-logos branch August 31, 2021 12:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants