SOLR-16408: TestHdfsUpdateLog, TestRecoveryHdfs, and TestRandomCollapseQParserPlugin call SolrTestCaseJ4.teardownTestCases instead of deleteCore #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seQParserPlugin try to deleteCore twice
risdenk
requested review from
epugh,
janhoy,
madrob,
HoustonPutman,
cpoerschke and
gerlowskija
epugh
approved these changes
Sep 9, 2022
|
No idea. There are a bunch of tests that do this in before/after test, but only a few in beforeclass/afterclass. The changes in SOLR-16187 at least gave a clue as to why this was hanging. |
risdenk
commented
Sep 15, 2022
solr/modules/hdfs/src/test/org/apache/solr/hdfs/search/TestRecoveryHdfs.java
Show resolved
Hide resolved
cpoerschke
reviewed
Sep 16, 2022
solr/core/src/test/org/apache/solr/search/TestRandomCollapseQParserPlugin.java
Show resolved
Hide resolved
solr/modules/hdfs/src/test/org/apache/solr/hdfs/search/TestRecoveryHdfs.java
Outdated
Show resolved
Hide resolved
solr/modules/hdfs/src/test/org/apache/solr/hdfs/update/TestHdfsUpdateLog.java
Outdated
Show resolved
Hide resolved
risdenk
changed the title
risdenk
added a commit
that referenced
this pull request
Sep 19, 2022
…seQParserPlugin call SolrTestCaseJ4.teardownTestCases instead of deleteCore (#1003)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16408
This uses
SolrTestCaseJ4AfterClass to cleanup and calldeleteCoreinstead of trying to do this inAfterClassin each of the tests themselves.