Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16406: Take SOLR_MODULES into account #1007

Merged
merged 1 commit into from Sep 17, 2022

Conversation

thomaswoeckinger
Copy link
Contributor

@thomaswoeckinger thomaswoeckinger commented Sep 12, 2022

https://issues.apache.org/jira/browse/SOLR-16406

Description

SOLR_MODULES (provided by solr.in.sh) is currently ignored.

Solution

Take SOLR_MODULES into account by changing solr and solr.cmd scripts

Tests

Added to /opt/solr/bin/solr and /opt/solr/bin/solr.in.sh locally and start the server

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@epugh
Copy link
Contributor

epugh commented Sep 12, 2022

From a "does this fix the problem" view, the changes LGTM.

@risdenk risdenk requested a review from janhoy September 12, 2022 13:41
@janhoy
Copy link
Contributor

janhoy commented Sep 13, 2022

@thomaswoeckinger can you add a CHANGES.txt entry for 9.1, under bugfixes, then we can merge.

@janhoy
Copy link
Contributor

janhoy commented Sep 16, 2022

Ping @thomaswoeckinger

@thomaswoeckinger
Copy link
Contributor Author

Sorry for the late response, i will add a entry tomorrow

@thomaswoeckinger
Copy link
Contributor Author

@janhoy Added CHANGES.txt entry for 9.1

@janhoy janhoy merged commit 1e6dd0e into apache:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants