New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-15730: Document SolrJ opt-in for 10x #1021
Conversation
Added "Major changes in Solr 10". Moved the "Upgrading 9.1" section to the page it should be on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment for 9.1 wording.
@@ -68,6 +68,11 @@ Due to changes in Lucene 9, that isn't possible any more. | |||
=== Querying and Indexing | |||
* Added Lucene91HnswVectorsFormat codec for DenseVectorField. In order to use the new codec, reindex is necessary. | |||
|
|||
=== SolrJ | |||
SolrJ is beginning to be split up. If you use ZooKeeper coordinates to create a `CloudSolrClient`, you will need to add a dependency on `solrj-zookeeper`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand, this will be a transitive dependency in Solr 9.1, so this text should say that no changes are needed as long as you enable automatic dependency resolution in maven/gradle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
SolrJ is beginning to be split up. If you use ZooKeeper coordinates to create a
CloudSolrClient
, you will need to add a dependency onsolrj-zookeeper
. If you use SolrJ's Maven POM to depend on SolrJ, then this should happen automatically through transitive resolution.
…to solrj-modules-10-docs
Wait I'm confused, can you clear this up @janhoy ? I thought that the |
You are right, and I thought about it too. But then it is a bit confusing too. You proposed to change how we do all this, didn't you? Perhaps we shold do that soon? |
Where we put notes on this has been confusing! I feel like it needs it's own developer documentation how-to! |
Right now our docs are structured such that we are expecting users to upgrade from an outdated minor version to the At this point we won't need to do anything for a major release, and links stay consistent even when the major version is cut. I can try to hack something together tomorrow if y'all want to see it to completion after that. |
Cassandra documented partly how it's done here https://issues.apache.org/jira/browse/SOLR-15901 I'm all for a restructure on this. Then the solr-10-upgrade-notes will talk about what's new in Solr 10 and 10.x, and it will clearly state that users upgrading from earlier 9.x versions or even from 8.x will need to consult those pages, which seems logical. |
The discussions are good but I think I can merge this finally, and back-port some aspects to branch_9x? |
Go ahead and merge, we can fix these things separately |
See https://issues.apache.org/jira/browse/SOLR-15730?focusedCommentId=17603208&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17603208
Added "Major changes in Solr 10".
Moved the "Upgrading 9.1" section to the page it should be on.
Someone please do a sanity check on the pages by rendering them locally. I believe this is via
gradlew buildLocalSite
. I can't get major-changes-in-solr-10.adoc to show up in the navigation; it's an orphaned page.