SOLR-16435: Add Request timeout to Http2SolrClient #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anshumg
reviewed
Sep 29, 2022
| @@ -519,7 +525,11 @@ private Request makeRequest(SolrRequest<?> solrRequest, String collection) | |||
|
|
|||
| private void decorateRequest(Request req, SolrRequest<?> solrRequest) { | |||
| req.header(HttpHeader.ACCEPT_ENCODING, null); | |||
| req.timeout(idleTimeout, TimeUnit.MILLISECONDS); | |||
| if (requestTimeout > 0) { | |||
There was a problem hiding this comment.
If someone accidentally sets this to 0, we'd just be ignoring it?
There was a problem hiding this comment.
I don't think it makes much difference. 0 means timeout disabled, but our client will only wait for idleTimeout (see listener.get(idleTimeout, TimeUnit.MILLISECONDS);), so we'll timeout anyway, and at that point, probably better to timeout the request, since the client won't consume it anyway. WDYT?
anshumg
approved these changes
Oct 3, 2022
tflobbe
force-pushed
the
request-timeout
branch
from
51cf447
to
15ae5b8
Compare
tflobbe
added a commit
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the option to Http2SolrClient. For the Cloud client, users need to use
withInternalClientBuilderand provide a builder, similar to how they use for setting the other timeouts, authentication, etc.Will update CHANGES once this gets reviewed, but my plan is to merge into 9.x