SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command. #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bruno-roustant
commented
Sep 29, 2022
bruno-roustant
commented
- Introduce the optional split.setPreferredLeaders prop on CollectionAdminRequest#SplitShard.
- Make SplitShardCommand support it and set the preferredLeader property on other replicas of each created sub-shard. Distributing the preferred leaders evenly.
- Introduce combined operations in CollectionsHandler, so that a CollectionOperation (e.g. SPLITSHARD_OP) can look at the request and (e.g. if split.setPreferredLeaders is set) create a sequence of operations to execute (e.g. split, wait for completion, rebalance leaders).
bruno-roustant
commented
Sep 29, 2022
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java
Outdated
Show resolved
Hide resolved
|
|
bruno-roustant
force-pushed
the
shardsplit
branch
from
50add9a
to
e931eef
Compare
bruno-roustant
force-pushed
the
shardsplit
branch
from
ac91e3e
to
546190b
Compare
|
@dsmiley I rebased with the recent works on these classes. Ready for a review. |
bruno-roustant
force-pushed
the
shardsplit
branch
from
546190b
to
05087ac
Compare
|
@dsmiley I refreshed to be up to date, and I added the solr.autoPreferredLeader property. |
dsmiley
reviewed
Dec 6, 2022
solr/CHANGES.txt
Outdated
| @@ -41,6 +41,8 @@ New Features | |||
|
|
|||
| * SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI (Jeanie Lam via Eric Pugh) | |||
|
|
|||
| * SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command. (Bruno Roustant) | |||
There was a problem hiding this comment.
People debate this sort of thing but I think of this as an improvement to a feature and not a new feature.
There was a problem hiding this comment.
I don't see Solr Ref Guide changes
| @@ -1205,7 +1205,6 @@ private void doDefensiveChecks(DistribPhase phase) { | |||
| } | |||
|
|
|||
| if ((isLeader && !localIsLeader) || (isSubShardLeader && !localIsLeader)) { | |||
| log.error("ClusterState says we are the leader, but locally we don't think so"); | |||
There was a problem hiding this comment.
commenting this seems to be out of scope
dsmiley
approved these changes
Dec 15, 2022
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.