SOLR-13880: Add test that creates/reloads/deletes collections #1105
Conversation
| tlogReplicas, | ||
| pullReplicas); | ||
| HttpGet createCollectionGet = new HttpGet(url); | ||
| ((CloudLegacySolrClient) cluster.getSolrClient()) |
There was a problem hiding this comment.
Do we need this to be CloudLegacySolrClient?
| import org.apache.solr.SolrTestCaseJ4.SuppressSSL; | ||
| import org.apache.solr.client.solrj.SolrServerException; | ||
| import org.apache.solr.client.solrj.impl.CloudLegacySolrClient; |
There was a problem hiding this comment.
turns out we use this to get a HttpClient in order to do a direct GET..
| private void createCollection( | ||
| int numShards, int nrtReplicas, int tlogReplicas, int pullReplicas, String collectionName) | ||
| throws SolrServerException, IOException { | ||
| switch (random().nextInt(3)) { |
There was a problem hiding this comment.
Seems weird these create strings - don't we have admin API wrappers around these? We shouldn't need to build straight httpget/httppost commands...
|
@risdenk there are a MILLION places where we create raw HttpGet in the tests, I saw that when I tried to migrate things to As far at not using an API, well, there are two examples, one using the SolrJ, the other with the long string.... |
yea more of a we can skip it now but probably has to be fixed at some point :) |
|
@risdenk what are your thoughts on the |
There was a problem hiding this comment.
The reason I didn't merge this back when I created the PR is that it didn't find any bugs (ran successfully all the time on my machine), so I was debating myself if the coverage added was worth the potential noise of unrelated failures (that we see all the time in Jenkins).
I'm fine with the PR if you guys think it's worth it.
| @@ -86,4 +96,107 @@ public void testReloadedLeaderStateAfterZkSessionLoss() throws Exception { | |||
|
|
|||
| log.info("testReloadedLeaderStateAfterZkSessionLoss succeeded ... shutting down now!"); | |||
| } | |||
|
|
|||
| @Repeat(iterations = 5) | |||
There was a problem hiding this comment.
is it worth having this set to 5? how long does this take? should we have maybe 2 here, and set it higher in nightly? not sure if that's possible
There was a problem hiding this comment.
two works for me... Makign the change.
https://issues.apache.org/jira/browse/SOLR-13880
Description
Migrate test from apache/lucene-solr#986 to current repo.
Solution
Additional testing.