New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-16416: Retry overseerPrioritizer ops on failure #1129
Merged
HoustonPutman
merged 8 commits into
apache:main
from
HoustonPutman:overseer-prioritizer-retry
Oct 26, 2022
Merged
SOLR-16416: Retry overseerPrioritizer ops on failure #1129
HoustonPutman
merged 8 commits into
apache:main
from
HoustonPutman:overseer-prioritizer-retry
Oct 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
reviewed
Oct 25, 2022
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java
Outdated
Show resolved
Hide resolved
@gerlowskija I have actually fixed the underlying issue. We were running overseer ops before actually registering all of the Solr handlers. |
risdenk
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - retry doesn't have a sleep yet.
HoustonPutman
added a commit
that referenced
this pull request
Oct 26, 2022
(cherry picked from commit 1738098)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16416
This should fix the failing test. No idea why the endpoints noted in the JIRA were unavailable when restarting the test nodes, but anyways it is good to retry this logic.