Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15397 Expose zookeeper status in the exporter, and in grafana da… #116

Merged
merged 5 commits into from
May 12, 2021

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented May 6, 2021

@janhoy janhoy requested a review from thelabdude May 6, 2021 15:11
janhoy added 4 commits May 7, 2021 11:32
Fix total OK count and report cluster as RED if OK==0
If no ZKs answer, and configured ZK_HOST is 1, assume "standalone"
New test for the failure case
Copy link
Contributor

@thelabdude thelabdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great in my env Jan!
Screen Shot 2021-05-07 at 2 09 15 PM

@janhoy
Copy link
Contributor Author

janhoy commented May 8, 2021

I ser you have double set of legends. Probably because of some label differences?

I have not tested any of this with standalone solr, do you know a way to disable a grafana row conditionally if we are not in cloud mode?

@janhoy janhoy merged commit 151539d into apache:main May 12, 2021
@janhoy janhoy deleted the solr15397-zookeeper-prometheus branch May 12, 2021 08:18
"steppedLine": false,
"targets": [
{
"exemplar": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thelabdude I noticed in an environment I was running this, that the Zookeeper graph was not working. Playing around in Grafana UI, I noticed that the "Examplar" buttons were checked for this panel only, and unchecking them made the graph appear again.

As I understand, Exemplars is some sort of distributed tracing support in Prometheus. I think we should remove this setting in solr git. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants