SOLR-15787: Fix FileSystemConfigSetService test failure on Windows #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
requested changes
Dec 14, 2022
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java
Outdated
Show resolved
Hide resolved
risdenk
requested changes
Dec 14, 2022
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java
Outdated
Show resolved
Hide resolved
|
Tested the latest changes on Mac and Windows and both pass ( |
dsmiley
requested changes
Jan 7, 2023
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/core/TestConfigSetService.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/core/TestConfigSetService.java
Outdated
Show resolved
Hide resolved
risdenk
changed the title
risdenk
approved these changes
Jan 9, 2023
mkhludnev
approved these changes
Jan 9, 2023
dsmiley
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
+1 Thanks @risdenk for finishing this and @NazerkeBS for starting this!
No CHANGES.txt necessary because this is really just an update to an existing entry there which was never released.
dsmiley
pushed a commit
that referenced
this pull request
Jan 10, 2023
…1239) Co-authored-by: Nazerke Seidan <nseidan@salesforce.com> Co-authored-by: Kevin Risden <krisden@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15787