Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16632: Add core name to periodic delete related log messages #1311

Closed
wants to merge 1 commit into from

Conversation

bszabo97
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-16632

Description

When expired documents are deleted periodically from the index we have a log message about the start and the end of this process.

In cases where we have multiple collections with TTL enabled it can be misleading that these messages do not contain the name of the actual collection/core on which the periodic delete is executed. The name of the core can be easily added to the log message.

Solution

I have added core.getName() as a parameter to the above mentioned log lines.

Tests

I have manually tested that the core name appears in the log messages after my modification.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

asfgit pushed a commit that referenced this pull request Feb 1, 2023
)

Co-authored-by: Andras Salamon <asalamon74@apache.org>
asfgit pushed a commit that referenced this pull request Feb 1, 2023
)

Co-authored-by: Andras Salamon <asalamon74@apache.org>
@asalamon74
Copy link
Contributor

Thanks @bszabo97 committed the change to main and branch_9x.

@asalamon74 asalamon74 closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants