SOLR-16635: Resolve crypto keys file path in MiniSolrCloudCluster #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumg
approved these changes
Jan 27, 2023
| @@ -89,6 +90,10 @@ | |||
| public class MiniSolrCloudCluster { | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); | |||
| private static final URL PRE_GENERATED_PRIVATE_K_URL = | |||
There was a problem hiding this comment.
nit-pick, but can we use KEY instead of K i.e. PRE_GENERATED_PRIVATE_KEY_URL
| @@ -89,6 +90,10 @@ | |||
| public class MiniSolrCloudCluster { | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); | |||
| private static final URL PRE_GENERATED_PRIVATE_K_URL = | |||
| MiniSolrCloudCluster.class.getClassLoader().getResource("cryptokeys/priv_key512_pkcs8.pem"); | |||
| private static final URL PRE_GENERATED_PUBLIC_K_URL = | |||
tflobbe
force-pushed
the
mini-cluster-keys
branch
from
7458c0f
to
b5778a3
Compare
risdenk
approved these changes
Jan 30, 2023
|
The failures I see in the test action are not reproducing and are common in Jenkins emails, so I assume they are unrelated to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By resolving the full path of the pre-generated crypto keys in
MiniSolrCloudClusterwe make sure it also works for third party projects testing using Solr test framework