SOLR-16641 - Generate gradle.properties from template #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhoy
reviewed
Feb 1, 2023
There was a problem hiding this comment.
I too like the approach of generating it in gradlew. But probably our customization should be clearly marked with some # BEGIN/END SOLR CUSTOMIZATION marker? Or we just do a one-liner source solr_preinit.sh which is easier to patch into new versions of gradlew?
|
Sorry for adding the review here instead of #1320, it was a mistake. I can add it there if you want, or I'll wait a few days to see how that PR evolves and review again. |
|
Sorry, I'll close this one but I'll remember the comments on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #1320 atm, I just want to test the crave.io check