Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16656: rid parameter missing from query logs #1364

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

stillalex
Copy link
Member

@stillalex stillalex commented Feb 16, 2023

https://issues.apache.org/jira/browse/SOLR-16656

Description

Moved isDistrib calculation before the decision to log rid, in order to be logged correctly.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@@ -272,18 +272,23 @@ public List<SearchComponent> getComponents() {
return result;
}

private boolean isDistrib(SolrQueryRequest req) {
boolean isZkAware = req.getCoreContainer().isZooKeeperAware();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18% of developers fix this issue

NULL_DEREFERENCE: object returned by req.getCoreContainer() could be null and is dereferenced at line 276.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@stillalex
Copy link
Member Author

rebased to fix the changes file conflicts

@stillalex
Copy link
Member Author

thank you @mkhludnev and @risdenk for approving. could one of you also merge it? I don't have the rights.

@risdenk risdenk changed the title SOLR-16656 rid parameter missing from query logs in Solr 9.x SOLR-16656: rid parameter missing from query logs Mar 1, 2023
@risdenk risdenk merged commit 35a9bed into apache:main Mar 1, 2023
@stillalex stillalex deleted the SOLR-16656 branch March 2, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants