Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-16668: Default to Java SSL for Http2SolrClient #1366

Merged
merged 5 commits into from Feb 22, 2023
Merged

SOLR-16668: Default to Java SSL for Http2SolrClient #1366

merged 5 commits into from Feb 22, 2023

Conversation

HoustonPutman
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-16668

Also added a bit of cleanup in the code.

janhoy
janhoy approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I must have overlooked the need for system-default truststore when doing that change. Will the warning logs re-appear with this change?

@HoustonPutman
Copy link
Contributor Author

I think that the warnings will be removed when #1367 is merged as well, since it changes the default of the trustAll parameter. So we can check after merging this PR and before merging #1367

@HoustonPutman HoustonPutman merged commit eb34d9f into apache:main Feb 22, 2023
@HoustonPutman HoustonPutman deleted the http2-ssl branch February 22, 2023 03:43
HoustonPutman added a commit that referenced this pull request Feb 22, 2023
@HoustonPutman
SOLR-16668: Default to Java SSL for Http2SolrClient (#1366)
afc3c45 
(cherry picked from commit eb34d9f)
@HoustonPutman HoustonPutman mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhoy janhoy janhoy approved these changes

@risdenk risdenk risdenk approved these changes

@markrmiller markrmiller Awaiting requested review from markrmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@HoustonPutman @janhoy @risdenk