SOLR-15928 Dim add collection buttons in Admin UI when no permission #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # solr/CHANGES.txt
janhoy
commented
Feb 17, 2023
epugh
reviewed
Feb 18, 2023
epugh
approved these changes
Feb 18, 2023
Yea, just tried to get a shorter version of |
|
It might be confusing as to why everything is disabled. How about changing the mouse cursor to not allowed one on hover? https://www.w3schools.com/cssref/pr_class_cursor.php |
That's exactly what this CSS does already :-) |
|
Now also disabling "Reload" button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15928
This is the first of several permission related edits to Admin UI. The "Add Collection" button was already disabled when user lacked
collection-admin-edit, but it was not dimmed/greyed so hard to understand why you could not click.